You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/10 15:28:13 UTC
[GitHub] [dubbo-go] awayings opened a new pull request #1510: add method name check for generalized service call.
awayings opened a new pull request #1510:
URL: https://github.com/apache/dubbo-go/pull/1510
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
add method name check for generalized service call.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #1510: add method name check for generalized service call.
Posted by GitBox <gi...@apache.org>.
AlexStocks closed pull request #1510:
URL: https://github.com/apache/dubbo-go/pull/1510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1510: add method name check for generalized service call.
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1510:
URL: https://github.com/apache/dubbo-go/pull/1510#discussion_r725784628
##########
File path: cluster/cluster_impl/failover_cluster_invoker.go
##########
@@ -45,6 +45,17 @@ func newFailoverClusterInvoker(directory cluster.Directory) protocol.Invoker {
}
}
+func getMethodName(invocation protocol.Invocation) string {
+ var methodName = invocation.MethodName()
+ if methodName == constant.GENERIC && len(invocation.Arguments()) > 0 {
Review comment:
Please consider using `isGenericInvocation` defined in `filter/generic/util.go` at line 52.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha commented on a change in pull request #1510: add method name check for generalized service call.
Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #1510:
URL: https://github.com/apache/dubbo-go/pull/1510#discussion_r730241930
##########
File path: cluster/cluster_impl/failover_cluster_invoker.go
##########
@@ -59,7 +70,7 @@ func (invoker *failoverClusterInvoker) Invoke(ctx context.Context, invocation pr
return &protocol.RPCResult{Err: err}
}
- methodName := invocation.MethodName()
Review comment:
这个旧方法被删掉了吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1510: add method name check for generalized service call.
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1510:
URL: https://github.com/apache/dubbo-go/pull/1510#discussion_r725784628
##########
File path: cluster/cluster_impl/failover_cluster_invoker.go
##########
@@ -45,6 +45,17 @@ func newFailoverClusterInvoker(directory cluster.Directory) protocol.Invoker {
}
}
+func getMethodName(invocation protocol.Invocation) string {
+ var methodName = invocation.MethodName()
+ if methodName == constant.GENERIC && len(invocation.Arguments()) > 0 {
Review comment:
Please consider replacing this line with `isGenericInvocation` defined in `filter/generic/util.go` at line 52 to determine if the invocation is generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org