You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/08/23 14:32:16 UTC
Re: Review Request 72789: Read the checkpointed CSI volume state
directly in protobuf message way.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/
-----------------------------------------------------------
(Updated Aug. 23, 2020, 10:32 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comment.
Summary (updated)
-----------------
Read the checkpointed CSI volume state directly in protobuf message way.
Bugs: MESOS-10153
https://issues.apache.org/jira/browse/MESOS-10153
Repository: mesos
Description (updated)
-------
Read the checkpointed CSI volume state directly in protobuf message way.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/2/
Changes: https://reviews.apache.org/r/72789/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72789: Refactored state recovery in `volume/csi`
isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/
-----------------------------------------------------------
(Updated Aug. 25, 2020, 9:21 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10155
https://issues.apache.org/jira/browse/MESOS-10155
Repository: mesos
Description
-------
Read the checkpointed CSI volume state directly in protobuf message way.
Diffs
-----
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72789: Refactored state recovery in `volume/csi`
isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/
-----------------------------------------------------------
(Updated Aug. 25, 2020, 9:18 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comment.
Summary (updated)
-----------------
Refactored state recovery in `volume/csi` isolator.
Bugs: MESOS-10153
https://issues.apache.org/jira/browse/MESOS-10153
Repository: mesos
Description
-------
Read the checkpointed CSI volume state directly in protobuf message way.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/3/
Changes: https://reviews.apache.org/r/72789/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72789: Read the checkpointed CSI volume state
directly in protobuf message way.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/#review221687
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp
Line 200 (original), 200 (patched)
<https://reviews.apache.org/r/72789/#comment310741>
Could I suggest a change to the commit message? Perhaps "Refactored state recovery in volume/csi isolator."? You could mention the part about using the templated protobuf helper function in the description if you want maybe?
- Greg Mann
On Aug. 23, 2020, 2:33 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72789/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2020, 2:33 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10153
> https://issues.apache.org/jira/browse/MESOS-10153
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Read the checkpointed CSI volume state directly in protobuf message way.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
>
>
> Diff: https://reviews.apache.org/r/72789/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72789: Read the checkpointed CSI volume state
directly in protobuf message way.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/#review221684
-----------------------------------------------------------
Bad patch!
Reviews applied: [72789]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72789
Error:
2020-08-23 15:46:50 URL:https://reviews.apache.org/r/72789/diff/raw/ [1771/1771] -> "72789.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf926.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/63/console
- Mesos Reviewbot
On Aug. 23, 2020, 2:33 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72789/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2020, 2:33 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10153
> https://issues.apache.org/jira/browse/MESOS-10153
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Read the checkpointed CSI volume state directly in protobuf message way.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
>
>
> Diff: https://reviews.apache.org/r/72789/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72789: Read the checkpointed CSI volume state
directly in protobuf message way.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72789/
-----------------------------------------------------------
(Updated Aug. 23, 2020, 10:33 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10153
https://issues.apache.org/jira/browse/MESOS-10153
Repository: mesos
Description
-------
Read the checkpointed CSI volume state directly in protobuf message way.
Diffs
-----
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp 535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/2/
Testing
-------
Thanks,
Qian Zhang