[jira] [Comment Edited] (SPARK-2667) getCallSiteInfo doesn't take into account that graphx is part of spark.

["Sean Owen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295421#comment-14295421 ] 

Sean Owen edited comment on SPARK-2667 at 1/28/15 5:25 PM:
-----------------------------------------------------------

Although the code has changed a lot since this was reported, it seems that the intent described in the comment has not:

{code}
  /**
   * When called inside a class in the spark package, returns the name of the user code class
   * (outside the spark package) that called into Spark, as well as which Spark method they called.
   * This is used, for example, to tell users where in their code each RDD got created.
   */
{code}

but the regex it uses further elaborates with:

{code}
  /**
   * A regular expression to match classes of the "core" Spark API that we want to skip when
   * finding the call site of a method.
   */
{code}

It is matching core Spark classes, not GraphX classes.


was (Author: srowen):
Although the code has changed a lot since this was reported, it seems that the intent described in the comment has not:

{code}
  /**
   * When called inside a class in the spark package, returns the name of the user code class
   * (outside the spark package) that called into Spark, as well as which Spark method they called.
   * This is used, for example, to tell users where in their code each RDD got created.
   */
{code}

It is matching core Spark classes, not GraphX classes.

> getCallSiteInfo doesn't take into account that graphx is part of spark.
> -----------------------------------------------------------------------
>
>                 Key: SPARK-2667
>                 URL: https://issues.apache.org/jira/browse/SPARK-2667
>             Project: Spark
>          Issue Type: Bug
>          Components: GraphX
>    Affects Versions: 1.0.0
>         Environment: Mac Os X, although its on all versions
>            Reporter: Adrian Budau
>            Priority: Trivial
>
> getCallSiteInfo from org.apache.spark.util.Utils uses a regex pattern to match when a function is part of spark or not. At the moment this does not include GraphX



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org