You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2026/09/11 08:49:10 UTC
[GH] (pekko-http/lazy-log-templates): Workflow run "Validate and test" is working again!
The GitHub Actions job "Validate and test" on pekko-http.git/lazy-log-templates has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
7427a368cbe1e24c67b16b40deef3ed1d9476bea / PJ Fanning <pj...@users.noreply.github.com>
Use lazy log templates instead of string interpolation
Motivation:
Several main-source log calls built their message with `s"..."`
interpolation, so the message was rendered even when the level was
disabled. A few of them also carried redundant `if (log.isXxxEnabled)`
guards, and one built an interpolated string that already contained
`{}` placeholders.
Modification:
Convert eager `s"..."` log messages to `LoggingAdapter` `{}` templates
with the values passed as arguments, so the message is only rendered
when the level is enabled. Drop the now-redundant `isDebugEnabled` /
`isErrorEnabled` guards in FrameOutHandler, Http2Blueprint and
NewHostConnectionPool. Remove the unnecessary `s` prefix from the
HttpsProxyGraphStage message, which had no interpolation at all, and
pass the slot message of NewHostConnectionPool as a template argument
rather than splicing it into the template. Rendered messages are
unchanged.
Result:
No message string is built for a disabled log level, and a slot error
message containing `{}` can no longer be mistaken for a placeholder.
Tests:
- sbt "http-core/compile" "http/compile" - success
- sbt "++3.3.8" "http-core/compile" "http/compile" - success
- sbt "http-core/testOnly org.apache.pekko.http.impl.engine.server.HttpServerSpec org.apache.pekko.http.impl.engine.ws.MessageSpec" - 139 passed
- sbt "http2-tests/testOnly org.apache.pekko.http.impl.engine.http2.Http2ServerSpec org.apache.pekko.http.impl.engine.http2.Http2ClientSpec" - 174 passed
- sbt "http-tests/testOnly org.apache.pekko.http.scaladsl.unmarshalling.sse.EventStreamParserOversizedSpec" - 18 passed
- sbt "http-core/scalafmt" "http/scalafmt" - no changes
References:
None - logging cleanup
Report URL: https://github.com/apache/pekko-http/actions/runs/34580288565
With regards,
GitHub Actions via GitBox
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org