You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hamilton.apache.org by sk...@apache.org on 2026/07/19 16:51:21 UTC
(hamilton) 04/04: Address PR review: fix LICENSE links and move bundling note to README
This is an automated email from the ASF dual-hosted git repository.
skrawcz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hamilton.git
commit ca53d6ce9158be1a57a09b7741227a08f2a80f4b
Author: Stefan Krawczyk <st...@cs.stanford.edu>
AuthorDate: Tue Jun 16 23:42:37 2026 -0600
Address PR review: fix LICENSE links and move bundling note to README
- READMEs (sdk, lsp, ui): point the License link at the package's own
bundled LICENSE (./LICENSE) instead of ../../LICENSE, which breaks in
the re-rooted release tarballs (jernejfrank)
- ui/backend/LICENSE: remove the prose about distribution forms / bundled
frontend; LICENSE should carry license terms, not narrative (pjfanning)
- ui/backend/README.md: move that bundled-frontend explanation into the
License section of the README
The bundled frontend's third-party license texts are still shipped in the
wheel at hamilton_ui/build/THIRD-PARTY-LICENSES.txt.
---
dev_tools/language_server/README.md | 2 +-
ui/backend/LICENSE | 16 ----------------
ui/backend/README.md | 14 +++++++++++++-
ui/sdk/README.md | 2 +-
4 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/dev_tools/language_server/README.md b/dev_tools/language_server/README.md
index b4c1c56a..2657b3ab 100644
--- a/dev_tools/language_server/README.md
+++ b/dev_tools/language_server/README.md
@@ -50,4 +50,4 @@ git, which is what you want when building from an unpacked source release.
# License
-The code here is licensed under the Apache 2.0 license. See the main repository [LICENSE](../../LICENSE) for details.
+The code here is licensed under the Apache 2.0 license. See the [LICENSE](LICENSE) file included with this package for details.
diff --git a/ui/backend/LICENSE b/ui/backend/LICENSE
index 9f830c4e..261eeb9e 100644
--- a/ui/backend/LICENSE
+++ b/ui/backend/LICENSE
@@ -199,19 +199,3 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-
--------------------------------
-
-This package is distributed in two forms:
-
- * The source distribution (sdist) contains only Apache Hamilton source
- code and is licensed under the Apache License, Version 2.0 above.
-
- * The binary distribution (wheel) additionally bundles a compiled
- frontend web application (hamilton_ui/build/) built from the
- TypeScript/React sources in ui/frontend/. That bundle includes
- third-party JavaScript dependencies (e.g. React, Redux, Chart.js,
- React Flow), each under permissive licenses (MIT, Apache-2.0, BSD,
- ISC, and similar). The full per-dependency license texts and
- copyright notices are included in the wheel at
- hamilton_ui/build/THIRD-PARTY-LICENSES.txt.
diff --git a/ui/backend/README.md b/ui/backend/README.md
index ac046d27..ad81b387 100644
--- a/ui/backend/README.md
+++ b/ui/backend/README.md
@@ -120,4 +120,16 @@ of these steps automatically.
## License
-Apache 2.0. See the main repository [LICENSE](../../LICENSE) for details.
+Apache 2.0. See the [LICENSE](LICENSE) file included with this package for details.
+
+This package is distributed in two forms:
+
+- The **source distribution** (sdist) contains only Apache Hamilton source code,
+ licensed under the Apache License, Version 2.0.
+- The **binary distribution** (wheel) additionally bundles a compiled frontend
+ web application (`hamilton_ui/build/`) built from the TypeScript/React sources
+ in `ui/frontend/`. That bundle includes third-party JavaScript dependencies
+ (e.g. React, Redux, Chart.js, React Flow), each under permissive licenses
+ (MIT, Apache-2.0, BSD, ISC, and similar). The full per-dependency license
+ texts and copyright notices are included in the wheel at
+ `hamilton_ui/build/THIRD-PARTY-LICENSES.txt`.
diff --git a/ui/sdk/README.md b/ui/sdk/README.md
index 746a9a30..18467b51 100644
--- a/ui/sdk/README.md
+++ b/ui/sdk/README.md
@@ -106,4 +106,4 @@ flit build --no-use-vcs
git, which is what you want when building from an unpacked source release.
# License
-The code here is licensed under the Apache 2.0 license. See the main repository [LICENSE](../../LICENSE) for details.
+The code here is licensed under the Apache 2.0 license. See the [LICENSE](LICENSE) file included with this package for details.