You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/05 23:50:23 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #506: Add window frame constructs - alternative

houqp commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646050062



##########
File path: datafusion/src/physical_plan/window_frames.rs
##########
@@ -0,0 +1,337 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       This mod is coupled with sqlparser AST and doesn't seem to be physical specific. Maybe it's better to move this mod into logical plane instead and reimport in physical plane?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org