You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2017/09/08 17:09:32 UTC
[whimsy] 02/02: decouple components from their parents
This is an automated email from the ASF dual-hosted git repository.
rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
commit 6e4d6fc006d5dc20e714bfb16910720295694c96
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Fri Sep 8 13:02:41 2017 -0400
decouple components from their parents
---
www/roster/views/pmc/committers.js.rb | 2 +-
www/roster/views/pmc/main.js.rb | 12 ++----------
www/roster/views/pmc/pmc.js.rb | 2 +-
www/roster/views/pmc/roster.js.rb | 2 +-
www/roster/views/ppmc/committers.js.rb | 2 +-
www/roster/views/ppmc/main.js.rb | 10 +---------
www/roster/views/ppmc/members.js.rb | 2 +-
www/roster/views/ppmc/mentors.js.rb | 2 +-
www/roster/views/ppmc/roster.js.rb | 2 +-
9 files changed, 10 insertions(+), 26 deletions(-)
diff --git a/www/roster/views/pmc/committers.js.rb b/www/roster/views/pmc/committers.js.rb
index 7a7468d..3baee6c 100644
--- a/www/roster/views/pmc/committers.js.rb
+++ b/www/roster/views/pmc/committers.js.rb
@@ -76,6 +76,6 @@ class PMCCommitter < Vue
# toggle checkbox
def toggleSelect(person)
person.selected = !person.selected
- PMC.refresh()
+ @@committee.refresh()
end
end
diff --git a/www/roster/views/pmc/main.js.rb b/www/roster/views/pmc/main.js.rb
index ce8c271..f52f559 100644
--- a/www/roster/views/pmc/main.js.rb
+++ b/www/roster/views/pmc/main.js.rb
@@ -199,20 +199,12 @@ class PMC < Vue
self.update(@@committee)
end
- # refresh the current page
- def refresh()
- Vue.forceUpdate()
- end
-
- def mounted()
- # export refesh method
- PMC.refresh = self.refresh
- end
-
# update committee from conformation form
def update(committee)
@committee = committee
+ @committee.refresh = proc { Vue.forceUpdate() }
+
if @attic == nil and not committee.established and defined? fetch
@attic = []
diff --git a/www/roster/views/pmc/pmc.js.rb b/www/roster/views/pmc/pmc.js.rb
index beaaa69..a3d4316 100644
--- a/www/roster/views/pmc/pmc.js.rb
+++ b/www/roster/views/pmc/pmc.js.rb
@@ -150,6 +150,6 @@ class PMCMember < Vue
# toggle checkbox
def toggleSelect(person)
person.selected = !person.selected
- PMC.refresh()
+ @@committee.refresh()
end
end
diff --git a/www/roster/views/pmc/roster.js.rb b/www/roster/views/pmc/roster.js.rb
index 36a6381..0976a93 100644
--- a/www/roster/views/pmc/roster.js.rb
+++ b/www/roster/views/pmc/roster.js.rb
@@ -65,6 +65,6 @@ class PMCRoster < Vue
def toggleSelect(person)
person.selected = !person.selected
- PMC.refresh()
+ @@committee.refresh()
end
end
diff --git a/www/roster/views/ppmc/committers.js.rb b/www/roster/views/ppmc/committers.js.rb
index 95001c6..9539dcd 100644
--- a/www/roster/views/ppmc/committers.js.rb
+++ b/www/roster/views/ppmc/committers.js.rb
@@ -110,6 +110,6 @@ class PPMCCommitter < Vue
# toggle checkbox
def toggleSelect(person)
person.selected = !person.selected
- PPMC.refresh()
+ @@ppmc.refresh()
end
end
diff --git a/www/roster/views/ppmc/main.js.rb b/www/roster/views/ppmc/main.js.rb
index 4cdc4a9..0423f42 100644
--- a/www/roster/views/ppmc/main.js.rb
+++ b/www/roster/views/ppmc/main.js.rb
@@ -214,16 +214,8 @@ class PPMC < Vue
# update ppmc from conformation form
def update(ppmc)
@ppmc = ppmc
- end
-
- # refresh the current page
- def refresh()
- Vue.forceUpdate()
- end
- def mounted()
- # export refesh method
- PPMC.refresh = self.refresh
+ @ppmc.refresh = proc { Vue.forceUpdate() }
end
# create project in ldap
diff --git a/www/roster/views/ppmc/members.js.rb b/www/roster/views/ppmc/members.js.rb
index 7142d2b..573c75e 100644
--- a/www/roster/views/ppmc/members.js.rb
+++ b/www/roster/views/ppmc/members.js.rb
@@ -90,6 +90,6 @@ class PPMCMember < Vue
# toggle checkbox
def toggleSelect(person)
person.selected = !person.selected
- PPMC.refresh()
+ @@ppmc.refresh()
end
end
diff --git a/www/roster/views/ppmc/mentors.js.rb b/www/roster/views/ppmc/mentors.js.rb
index 9bcabe4..86efb2d 100644
--- a/www/roster/views/ppmc/mentors.js.rb
+++ b/www/roster/views/ppmc/mentors.js.rb
@@ -94,6 +94,6 @@ class PPMCMentor < Vue
# toggle checkbox
def toggleSelect(person)
person.selected = !person.selected
- PPMC.refresh()
+ @@ppmc.refresh()
end
end
diff --git a/www/roster/views/ppmc/roster.js.rb b/www/roster/views/ppmc/roster.js.rb
index bcbf226..67c2c67 100644
--- a/www/roster/views/ppmc/roster.js.rb
+++ b/www/roster/views/ppmc/roster.js.rb
@@ -65,6 +65,6 @@ class PPMCRoster < Vue
def toggleSelect(person)
person.selected = !person.selected
- PPMC.refresh()
+ @@ppmc.refresh()
end
end
--
To stop receiving notification emails like this one, please contact
"commits@whimsical.apache.org" <co...@whimsical.apache.org>.