You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/07/27 19:18:30 UTC

[GitHub] [incubator-eventmesh] xiaoyang-sde opened a new pull request, #1046: [WIP] EventMesh Dashboard: Configuration

xiaoyang-sde opened a new pull request, #1046:
URL: https://github.com/apache/incubator-eventmesh/pull/1046

   ### Motivation
   
   The dashboard page displays the current configuration of EventMesh.
   
   <img width="1408" alt="Screen Shot 2022-07-27 at 12 17 51 PM" src="https://user-images.githubusercontent.com/13134143/181354253-bf79e433-9eb6-409a-a17e-2e1cc37c0d45.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 merged pull request #1046: EventMesh Dashboard: Configuration

Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #1046:
URL: https://github.com/apache/incubator-eventmesh/pull/1046


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xiaoyang-sde commented on pull request #1046: [WIP] EventMesh Dashboard: Configuration

Posted by GitBox <gi...@apache.org>.
xiaoyang-sde commented on PR #1046:
URL: https://github.com/apache/incubator-eventmesh/pull/1046#issuecomment-1197585912

   > The license check did not pass, please check if the license was added, or the format is not accurate?
   
   Yes I will add the missing licenses later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1046: [WIP] EventMesh Dashboard: Configuration

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1046:
URL: https://github.com/apache/incubator-eventmesh/pull/1046#issuecomment-1197283824

   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1046](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30bb96f) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/e7ba6e2dcc2e0bce787b3bbb2b678f07b1032e44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7ba6e2) will **decrease** coverage by `0.49%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #1046      +/-   ##
   ===========================================
   - Coverage      9.68%   9.19%   -0.50%     
   + Complexity      610     580      -30     
   ===========================================
     Files           363     361       -2     
     Lines         23130   22936     -194     
     Branches       2551    2514      -37     
   ===========================================
   - Hits           2240    2108     -132     
   + Misses        20687   20633      -54     
   + Partials        203     195       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ime/admin/controller/EventMeshAdminController.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2NvbnRyb2xsZXIvRXZlbnRNZXNoQWRtaW5Db250cm9sbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...eventmesh/runtime/admin/handler/ClientHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvQ2xpZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...sh/runtime/admin/handler/ConfigurationHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvQ29uZmlndXJhdGlvbkhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...esh/runtime/admin/request/DeleteClientRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlQ2xpZW50UmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...apache/eventmesh/runtime/admin/response/Error.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3Jlc3BvbnNlL0Vycm9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...mesh/runtime/admin/response/GetClientResponse.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3Jlc3BvbnNlL0dldENsaWVudFJlc3BvbnNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ntime/admin/response/GetConfigurationResponse.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3Jlc3BvbnNlL0dldENvbmZpZ3VyYXRpb25SZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...entmesh/runtime/admin/utils/HttpExchangeUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3V0aWxzL0h0dHBFeGNoYW5nZVV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...pache/eventmesh/runtime/admin/utils/JsonUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3V0aWxzL0pzb25VdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...apache/eventmesh/runtime/boot/EventMeshServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1046/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] github-actions[bot] commented on a diff in pull request #1046: [WIP] EventMesh Dashboard: Configuration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #1046:
URL: https://github.com/apache/incubator-eventmesh/pull/1046#discussion_r931505790


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/response/GetConfigurationResponse.java:
##########
@@ -0,0 +1,54 @@
+package org.apache.eventmesh.runtime.admin.response;

Review Comment:
   ```suggestion
   /*
    * Licensed to the Apache Software Foundation (ASF) under one
    * or more contributor license agreements.  See the NOTICE file
    * distributed with this work for additional information
    * regarding copyright ownership.  The ASF licenses this file
    * to you under the Apache License, Version 2.0 (the
    * "License"); you may not use this file except in compliance
    * with the License.  You may obtain a copy of the License at
    *
    *   http://www.apache.org/licenses/LICENSE-2.0
    *
    * Unless required by applicable law or agreed to in writing,
    * software distributed under the License is distributed on an
    * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    * KIND, either express or implied.  See the License for the
    * specific language governing permissions and limitations
    * under the License.
    */
   
   package org.apache.eventmesh.runtime.admin.response;
   ```
   <!-- license-eye hidden identification -->



##########
eventmesh-dashboard/next-env.d.ts:
##########
@@ -0,0 +1,5 @@
+/// <reference types="next" />

Review Comment:
   ```suggestion
   /*
    * Licensed to the Apache Software Foundation (ASF) under one
    * or more contributor license agreements.  See the NOTICE file
    * distributed with this work for additional information
    * regarding copyright ownership.  The ASF licenses this file
    * to you under the Apache License, Version 2.0 (the
    * "License"); you may not use this file except in compliance
    * with the License.  You may obtain a copy of the License at
    *
    *   http://www.apache.org/licenses/LICENSE-2.0
    *
    * Unless required by applicable law or agreed to in writing,
    * software distributed under the License is distributed on an
    * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    * KIND, either express or implied.  See the License for the
    * specific language governing permissions and limitations
    * under the License.
    */
   
   /// <reference types="next" />
   ```
   <!-- license-eye hidden identification -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] Alonexc commented on pull request #1046: [WIP] EventMesh Dashboard: Configuration

Posted by GitBox <gi...@apache.org>.
Alonexc commented on PR #1046:
URL: https://github.com/apache/incubator-eventmesh/pull/1046#issuecomment-1197562596

   The license check did not pass, please check if the license was added, or the format is not accurate?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org