You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2024/08/10 20:30:22 UTC
Re: [PR] feat(GAQ): Add Redis Sentinel Support for Global Async Queries [superset]
codecov[bot] commented on PR #29912:
URL: https://github.com/apache/superset/pull/29912#issuecomment-2282269987
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/29912?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `58.33333%` with `30 lines` in your changes missing coverage. Please review.
> Project coverage is 65.05%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fa85476`)](https://app.codecov.io/gh/apache/superset/commit/fa854767d6aa2f1f8a1f03e208bd502e60b4a445?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 579 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/29912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/async\_events/async\_query\_manager.py](https://app.codecov.io/gh/apache/superset/pull/29912?src=pr&el=tree&filepath=superset%2Fasync_events%2Fasync_query_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2FzeW5jX3F1ZXJ5X21hbmFnZXIucHk=) | 53.12% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/29912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/async\_events/cache\_backend.py](https://app.codecov.io/gh/apache/superset/pull/29912?src=pr&el=tree&filepath=superset%2Fasync_events%2Fcache_backend.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYXN5bmNfZXZlbnRzL2NhY2hlX2JhY2tlbmQucHk=) | 59.45% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/29912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #29912 +/- ##
==========================================
+ Coverage 60.48% 65.05% +4.56%
==========================================
Files 1931 528 -1403
Lines 76236 38112 -38124
Branches 8568 0 -8568
==========================================
- Hits 46114 24793 -21321
+ Misses 28017 13319 -14698
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/29912/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/29912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.00% <38.88%> (-0.16%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/29912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/29912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.57% <58.33%> (-0.23%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/29912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.05% <58.33%> (+1.56%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/29912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.33% <40.27%> (+2.70%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/29912?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org