You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2025/04/01 03:05:37 UTC

Re: [PR] [CALCITE-6909] ClickHouse dialect should limit the Precision and Scale of the Decimal type to be within 76 [calcite]

xuzifu666 commented on code in PR #4261:
URL: https://github.com/apache/calcite/pull/4261#discussion_r2022066627


##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -9652,6 +9666,40 @@ Sql withPostgresqlModifiedDecimalTypeSystem() {
       return dialect(postgresqlSqlDialect);
     }
 
+    Sql withClickHouseModifiedDecimalTypeSystem() {
+      final ClickHouseSqlDialect clickHouseSqlDialect =
+          new ClickHouseSqlDialect(ClickHouseSqlDialect.DEFAULT_CONTEXT
+              .withDataTypeSystem(

Review Comment:
   Make sense, had changed to reuse ClickHouseSqlDialect.TYPE_SYSTEM here, thanks~ @mihaibudiu 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org