You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org> on 2007/06/06 02:47:26 UTC
[jira] Created: (TRINIDAD-49) ignore skin-addition's jar ordering
when generating the stylesheet hashcode.
ignore skin-addition's jar ordering when generating the stylesheet hashcode.
----------------------------------------------------------------------------
Key: TRINIDAD-49
URL: https://issues.apache.org/jira/browse/TRINIDAD-49
Project: MyFaces Trinidad
Issue Type: Bug
Components: Skinning
Affects Versions: 1.0.1-core
Reporter: Jeanne Waldman
BACKGROUND:
Our generated css file (from the skin's css file) includes a 'hashcode' in the name of the file. This is the StyleSheetDocument's id. We added this recently so that the browser won't cache old versions of the css. Changing the name of the file when the contents change fixes this.
We are also using it for portal work to decide whether or not the stylesheet on the producer matches the stylesheet on the consumer. If they match, then we know it is safe to use the consumer's stylesheet in the producer. This is to help with performance.
BUG:
This bug has to do with using the hashcode for portal AND skin-additions in the trinidad-skins.xml file in jars on the classpath.
Currently the hashcode calculation depends on the order of the skin-additions. If the order of the jars that contain the skin-additions changes, the StyleSheetDocumentId (aka hashcode) will change.
Ideally we shouldn't depend on the skin-addition order. A bug exists in a portal testcase where they don't have control over the jar order, and they are getting different hashcodes in the producer and the consumer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.