[jira] Closed: (FTPSERVER-222) Enhance the Ftplet.afterCommand method to include the result of the command that was executed

["Niklas Gustavsson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FTPSERVER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson closed FTPSERVER-222.
---------------------------------------

    Resolution: Fixed
      Assignee: Niklas Gustavsson

Modified patch applied in rev 719389. Thanks for your work on this!

The modifications:
* Fixed broken tests
* Did not include the FtpReply in the DefaultFtplet callbacks (like onLogin) since it would silently break every DefaultFtplet subclass out there. If you need the reply, you need to override afterCommand.

Hope your okay with these changes Sai? if you got the time, I would love to see some unit tests for this patch. 

> Enhance the Ftplet.afterCommand method to include the result of the command that was executed
> ---------------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-222
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-222
>             Project: FtpServer
>          Issue Type: Improvement
>          Components: Ftplets
>            Reporter: Sai Pullabhotla
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0-M4
>
>         Attachments: ftpserver_patch.txt
>
>
> The aftterCommand method in the Ftplet interface is a great way to listen for events from the FtpServer, however, this call back method does not tell anything about the result of the command execution. 
> Change the signature of this method to include the result of the command. 
> More information on this is available at http://www.mail-archive.com/ftpserver-users@mina.apache.org/msg00407.html. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.