using LF in comment impossible since 1.6.x ?

[Marc Lustig <ml...@marclustig.com>]

Hi,

since upgrading to 1.6.5 we cannot use log-messages anymore that contain
line-breaks.

This problem occurs in Subversive/Eclipse on windows. 
The problem does not occur when using the -F option on Linux to use
file-bases commit-message.
-- 
View this message in context: http://old.nabble.com/using-LF-in-comment-impossible-since-1.6.x----tp26126708p26126708.html
Sent from the Subversion Users mailing list archive at Nabble.com.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2412963

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].

Re: using LF in comment impossible since 1.6.x ?

[Mark Phippard <ma...@gmail.com>]

On Fri, Oct 30, 2009 at 4:49 AM, Marc Lustig <ml...@marclustig.com> wrote:

> since upgrading to 1.6.5 we cannot use log-messages anymore that contain
> line-breaks.
>
> This problem occurs in Subversive/Eclipse on windows.
> The problem does not occur when using the -F option on Linux to use
> file-bases commit-message.

Subversion log messages and also the content of all multi-line
versioned properties that are "reserved" by Subversion (the ones that
start with "svn:") cannot contain any line ending characters except
for LF.

This has always been true, but the Subversion server did not start
enforcing it until 1.6.x.

The problem is that the client API, for whatever reason, does not
normalize these line endings.  So it is up the users of the API to do
this before calling the API to send the data to the server.  As was
pointed out, in Subclipse we fixed this earlier in the year before 1.6
was GA.  It sounds like Subversive needs a similar fix.

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2412996

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].

Re: using LF in comment impossible since 1.6.x ?

["B. Smith-Mannschott" <bs...@gmail.com>]

On Fri, Oct 30, 2009 at 09:49, Marc Lustig <ml...@marclustig.com> wrote:
> Hi,
>
> since upgrading to 1.6.5 we cannot use log-messages anymore that contain
> line-breaks.

I suspect that you can't use log-messages which contain the two-byte
sequence CR/LF as used in Windows to terminate lines. The Subversion
libraries want bare LF for multi-line svn: property values. (They've
been requiring it since 1.6.0)

This sounds like a bug in Subversive. Subclipse got this wrong
initially too, but fixed in in r4373 (2009-03-30) on trunk.

> This problem occurs in Subversive/Eclipse on windows.
> The problem does not occur when using the -F option on Linux to use
> file-bases commit-message.

I suspect the text file *on* *linux* uses bare LF to terminate lines,
which is acceptable to Subversion 1.6.x.

// Ben

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2412995

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].