You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/08 11:52:49 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #29670: [SPARK-32815][ML] Fix LibSVM data source loading error on file paths with glob metacharacters

cloud-fan commented on a change in pull request #29670:
URL: https://github.com/apache/spark/pull/29670#discussion_r484857152



##########
File path: mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMRelation.scala
##########
@@ -100,7 +100,7 @@ private[libsvm] class LibSVMFileFormat
         "though the input. If you know the number in advance, please specify it via " +
         "'numFeatures' option to avoid the extra scan.")
 
-      val paths = files.map(_.getPath.toUri.toString)

Review comment:
       is this change related?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org