You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2022/12/22 15:29:08 UTC
[Bug 66397] New: [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
Bug ID: 66397
Summary: [PATCH] fix doc of createTempFile in TempFile and
improve file operation with Java NIO
Product: POI
Version: 5.3.x-dev
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: POI Overall
Assignee: dev@poi.apache.org
Reporter: lushaoqiang27@gmail.com
Target Milestone: ---
Created attachment 38453
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38453&action=edit
Patch file generated by ant
Fix doc of createTempFile in TempFile.
Improve file operation with Java NIO in DefaultTempFileCreationStrategy,
TempFileUtils, TestTempFileThreaded.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
* Is more code synchronization a good thing? With Project Loom, code
synchronization can cause real issues. Would it be possible to consider using
ReentrantLock or some other approach to locking?
* Can you actually explain what the improvements are? It's not obvious from
your patch what advantages there are in your new code.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
lsq27 <lu...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and replace synchronized with ReentrantLock
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38453|application/x-gzip |application/x-gtar
mime type| |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and replace synchronized with ReentrantLock
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |68983
Referenced Bugs:
https://bz.apache.org/bugzilla/show_bug.cgi?id=68983
[Bug 68983] POI can't create poifiles sub dir if temp dir is a symlink
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and replace synchronized with ReentrantLock
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
--- Comment #3 from PJ Fanning <fa...@yahoo.com> ---
Thanks - added with r1906238
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
lsq27 <lu...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38453|0 |1
is obsolete| |
--- Comment #2 from lsq27 <lu...@gmail.com> ---
Created attachment 38455
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38455&action=edit
second patch
Thanks for suggestions.
The new patch description is as follows.
* Make temp directory initialized only once with double-checked locking in
DefaultTempFileCreationStrategy#createPOIFilesDirectory().
* Replace createTempDirectory with Files.createTempDirectory in
DefaultTempFileCreationStrategy#createTempDirectory(String) FIXME
* Replace File instantiate with Paths to make code more concise in
TempFileUtils and TestTempFileThreaded.
* Fix doc of createTempFile in TempFile.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and replace synchronized with ReentrantLock
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and replace synchronized with ReentrantLock
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
--- Comment #4 from Jürgen Zeller <jz...@jzeller.eu> ---
This patch introduced the bug described in
https://bz.apache.org/bugzilla/show_bug.cgi?id=68983, Files.createDirectories()
does not work with sym links, see 68983 for details.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and replace synchronized with ReentrantLock
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
lsq27 <lu...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[PATCH] fix doc of |[PATCH] fix doc of
|createTempFile in TempFile |createTempFile in TempFile
|and improve file operation |and replace synchronized
|with Java NIO |with ReentrantLock
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 66397] [PATCH] fix doc of createTempFile in TempFile and improve file operation with Java NIO
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66397
lsq27 <lu...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38453|Patch file generated by ant |patch.tar.gz generated by
description| |ant
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org