You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/01/16 04:47:08 UTC
[PR] [SPARK-46677][CONNECT][FOLLOWUPS] Fix `dataset.col("*")` in Scala Client [spark]
zhengruifeng opened a new pull request, #44748:
URL: https://github.com/apache/spark/pull/44748
### What changes were proposed in this pull request?
this PR is a followup of https://github.com/apache/spark/pull/44689, to fix `dataset.col("*")` in Scala Client
### Why are the changes needed?
fix `dataset.col("*")` resolution
### Does this PR introduce _any_ user-facing change?
yes, bug fix
### How was this patch tested?
added ut
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-46677][CONNECT][FOLLOWUPS] Fix `dataset.col("*")` in Scala Client [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #44748:
URL: https://github.com/apache/spark/pull/44748#issuecomment-1893248701
maybe we should use `[FOLLOWUP]` in pr title ? `[FOLLOWUPS]` does not exist before `[SPARK-43611][PS][CONNECT][TESTS][FOLLOWUPS] Enable more tests` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46677][CONNECT][FOLLOWUP] Fix `dataset.col("*")` in Scala Client [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #44748: [SPARK-46677][CONNECT][FOLLOWUP] Fix `dataset.col("*")` in Scala Client
URL: https://github.com/apache/spark/pull/44748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46677][CONNECT][FOLLOWUPS] Fix `dataset.col("*")` in Scala Client [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44748:
URL: https://github.com/apache/spark/pull/44748#issuecomment-1893240007
There is an issue on `count(df.col("*"))`, I am going to fix it in a separate PR first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46677][CONNECT][FOLLOWUP] Fix `dataset.col("*")` in Scala Client [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44748:
URL: https://github.com/apache/spark/pull/44748#issuecomment-1893617939
merged to master, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org