You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Kay Kay (JIRA)" <ji...@apache.org> on 2009/12/30 11:47:29 UTC

[jira] Created: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
---------------------------------------------------------------------------------

                 Key: MAPREDUCE-1346
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
             Project: Hadoop Map/Reduce
          Issue Type: Bug
    Affects Versions: 0.20.2
            Reporter: Kay Kay
         Attachments: MAPREDUCE-1346.patch

TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 

Cleanup methods as part of setUp refactored to tearDown to accomplish that. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795404#action_12795404 ] 

Kay Kay commented on MAPREDUCE-1346:
------------------------------------

Thanks Todd. Then - I believe this can be closed as duplicate?

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795690#action_12795690 ] 

Kay Kay commented on MAPREDUCE-1346:
------------------------------------

Leaving this open to revisit text fixtures of contrib/streaming after MAPREDUCE-1155 is committed. 

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated MAPREDUCE-1346:
-------------------------------

    Fix Version/s: 0.20.2
           Status: Patch Available  (was: Open)

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1346:
-------------------------------------

    Fix Version/s:     (was: 0.20.2)

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796224#action_12796224 ] 

Konstantin Boudnik commented on MAPREDUCE-1346:
-----------------------------------------------

I believe it should read 'test fixtures'? 

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated MAPREDUCE-1346:
-------------------------------------

    Status: Open  (was: Patch Available)

The patch no longer applies. Please update or mark as duplicate as appropriate

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795412#action_12795412 ] 

Todd Lipcon commented on MAPREDUCE-1346:
----------------------------------------

I think so - if you could review MAPREDUCE-1155 that would be great :) I didn't make the tests _good_, but it should be a small improvement ;-)

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796233#action_12796233 ] 

Kay Kay commented on MAPREDUCE-1346:
------------------------------------

oops.yes - i meant 'test' fixtures 

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1346:
-----------------------------------------------

    Component/s: contrib/streaming
                 test

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/streaming, test
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated MAPREDUCE-1346:
-------------------------------

    Description: 
TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 

Cleanup methods as part of setUp refactored to tearDown to accomplish that. 

Because of incorrect text fixtures - subsequent test cases fail. 

  was:
TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 

Cleanup methods as part of setUp refactored to tearDown to accomplish that. 


> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795384#action_12795384 ] 

Hadoop QA commented on MAPREDUCE-1346:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12429132/MAPREDUCE-1346.patch
  against trunk revision 894165.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/245/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/245/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/245/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/245/console

This message is automatically generated.

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795347#action_12795347 ] 

Todd Lipcon commented on MAPREDUCE-1346:
----------------------------------------

See MAPREDUCE-1155

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 
> Because of incorrect text fixtures - subsequent test cases fail. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Kay updated MAPREDUCE-1346:
-------------------------------

    Attachment: MAPREDUCE-1346.patch

Fixtures in TestStreamingExitStatus properly refactored. 

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1346) TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place

Posted by "Kay Kay (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795281#action_12795281 ] 

Kay Kay commented on MAPREDUCE-1346:
------------------------------------

Once successful - need to revisit the test fixtures  of Streaming to make sure the cleanup happens appropriately in their respective tearDown()  and not as a stop-gap measure in setUp() methods. 

> TestStreamingExitStatus / TestStreamingKeyValue - correct text fixtures in place 
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1346
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1346
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: MAPREDUCE-1346.patch
>
>
> TestStreamingExitStatus does not have the correct text fixtures , of deleting the input / output files after the last test run. 
> Cleanup methods as part of setUp refactored to tearDown to accomplish that. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.