[jira] Updated: (MYFACES-306) JSCookMenu: Icon field should be null instead of empty string if not specify in navigationMenuItem

["Keijo Nurmes (JIRA)" <my...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/MYFACES-306?page=all ]

Keijo Nurmes updated MYFACES-306:
---------------------------------

    Attachment: frontIconJsCook_patch.txt

I had same problem a while ago. It worked fine in earlier version.  
This little patch to HtmlJSCookMenuRenderer.java seems to fix it.  


> JSCookMenu: Icon field should be null instead of empty string if not specify in navigationMenuItem
> --------------------------------------------------------------------------------------------------
>
>          Key: MYFACES-306
>          URL: http://issues.apache.org/jira/browse/MYFACES-306
>      Project: MyFaces
>         Type: Bug
>     Reporter: Cheng Kai Cheung
>  Attachments: frontIconJsCook_patch.txt
>
> In my application, I have no icon in all menu items. I wrote the following in my JSP, without using the 'icon' attribute.
>    <x:navigationMenuItem id="nav_0" itemLabel="#{navigation_messages['home']}" action="go_home"/>
> However, the javascript generated is:
>    [['', 'Home', '_id6:go_home', '#', null],   ...   ]
> But what I expect should be:
>    [[null, 'Home', '_id6:go_home', '#', null],   ...   ]
> If null string is generated, JSCookmenu will ignore javascript property "mainFolderLeft" in theme.js, causing some spacing problem between menu items.
> KC

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira