You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/05/25 20:46:10 UTC
Review Request 34656: Scaling PK/FK's selectivity for stats annotation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34656/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now, the computation of the selectivity of FK side based on PK side does not take into consideration of the range of FK and the range of PK.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7b48b8b
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 571c050
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 4cd9120
ql/src/test/results/clientpositive/annotate_stats_join.q.out 66e944b
ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out 66e0e9f
ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 75ad4e7
ql/src/test/results/clientpositive/tez/vector_null_projection.q.out 9b7b698
ql/src/test/results/clientpositive/udf_crc32.q.out 8280210
ql/src/test/results/clientpositive/udf_sha1.q.out ea7c805
ql/src/test/results/clientpositive/vector_join30.q.out 57f9aeb
Diff: https://reviews.apache.org/r/34656/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 34656: Scaling PK/FK's selectivity for stats
annotation
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34656/#review85212
-----------------------------------------------------------
Ship it!
Ship It!
- John Pullokkaran
On May 25, 2015, 6:46 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34656/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 6:46 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now, the computation of the selectivity of FK side based on PK side does not take into consideration of the range of FK and the range of PK.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7b48b8b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 571c050
> ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 4cd9120
> ql/src/test/results/clientpositive/annotate_stats_join.q.out 66e944b
> ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out 66e0e9f
> ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 75ad4e7
> ql/src/test/results/clientpositive/tez/vector_null_projection.q.out 9b7b698
> ql/src/test/results/clientpositive/udf_crc32.q.out 8280210
> ql/src/test/results/clientpositive/udf_sha1.q.out ea7c805
> ql/src/test/results/clientpositive/vector_join30.q.out 57f9aeb
>
> Diff: https://reviews.apache.org/r/34656/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 34656: Scaling PK/FK's selectivity for stats
annotation
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34656/#review85211
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
<https://reviews.apache.org/r/34656/#comment136726>
Add comments here about pk-fk & on logic step
- John Pullokkaran
On May 25, 2015, 6:46 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34656/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 6:46 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now, the computation of the selectivity of FK side based on PK side does not take into consideration of the range of FK and the range of PK.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7b48b8b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 571c050
> ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 4cd9120
> ql/src/test/results/clientpositive/annotate_stats_join.q.out 66e944b
> ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out 66e0e9f
> ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 75ad4e7
> ql/src/test/results/clientpositive/tez/vector_null_projection.q.out 9b7b698
> ql/src/test/results/clientpositive/udf_crc32.q.out 8280210
> ql/src/test/results/clientpositive/udf_sha1.q.out ea7c805
> ql/src/test/results/clientpositive/vector_join30.q.out 57f9aeb
>
> Diff: https://reviews.apache.org/r/34656/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 34656: Scaling PK/FK's selectivity for stats
annotation
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34656/
-----------------------------------------------------------
(Updated May 26, 2015, 6:44 p.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Changes
-------
address John's comments and remove spaces.
Repository: hive-git
Description
-------
Right now, the computation of the selectivity of FK side based on PK side does not take into consideration of the range of FK and the range of PK.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7b48b8b
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 571c050
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 4cd9120
ql/src/test/results/clientpositive/annotate_stats_join.q.out 66e944b
ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out 66e0e9f
ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 75ad4e7
ql/src/test/results/clientpositive/tez/vector_null_projection.q.out 9b7b698
ql/src/test/results/clientpositive/udf_crc32.q.out 8280210
ql/src/test/results/clientpositive/udf_sha1.q.out ea7c805
ql/src/test/results/clientpositive/vector_join30.q.out 57f9aeb
Diff: https://reviews.apache.org/r/34656/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 34656: Scaling PK/FK's selectivity for stats
annotation
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34656/
-----------------------------------------------------------
(Updated May 26, 2015, 6:42 p.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now, the computation of the selectivity of FK side based on PK side does not take into consideration of the range of FK and the range of PK.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7b48b8b
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 571c050
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 4cd9120
ql/src/test/results/clientpositive/annotate_stats_join.q.out 66e944b
ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out 66e0e9f
ql/src/test/results/clientpositive/spark/annotate_stats_join.q.out 75ad4e7
ql/src/test/results/clientpositive/tez/vector_null_projection.q.out 9b7b698
ql/src/test/results/clientpositive/udf_crc32.q.out 8280210
ql/src/test/results/clientpositive/udf_sha1.q.out ea7c805
ql/src/test/results/clientpositive/vector_join30.q.out 57f9aeb
Diff: https://reviews.apache.org/r/34656/diff/
Testing
-------
Thanks,
pengcheng xiong