You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/01 17:21:47 UTC
Re: Review Request 19853: Patch for KAFKA-1344
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19853/#review39159
-----------------------------------------------------------
Thanks for the patch. Some comments.
1. Perhaps we could just get rid of the --compress option and just use --compression-codec, but make it optional.
2. Could you add the right codec in OldProducer too?
- Jun Rao
On March 31, 2014, 6:14 p.m., Ivan Lyutov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19853/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 6:14 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1344
> https://issues.apache.org/jira/browse/KAFKA-1344
>
>
> Repository: kafka
>
>
> Description
> -------
>
> [KAFKA-1344] - Added compression codec option feature for ConsoleProducer
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/producer/ConsoleProducer.scala 57386b16988afa17792888fbebb285c174b117f4
>
> Diff: https://reviews.apache.org/r/19853/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Lyutov
>
>