You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2024/01/31 14:03:05 UTC
[PR] [YUNIKORN-2371] Add failed headroom checks to the allocation log [yunikorn-core]
pbacsko opened a new pull request, #781:
URL: https://github.com/apache/yunikorn-core/pull/781
### What is this PR for?
Show failed headroom checks in the allocation log to help debugging.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2371
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2371] Add failed headroom checks to the allocation log [yunikorn-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #781:
URL: https://github.com/apache/yunikorn-core/pull/781#issuecomment-1919170171
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/781?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d7c6fa7`)](https://app.codecov.io/gh/apache/yunikorn-core/commit/d7c6fa7ca5756150633844345523016c5aee5471?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 78.25% compared to head [(`abca53a`)](https://app.codecov.io/gh/apache/yunikorn-core/pull/781?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 78.25%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 78.25% 78.25% -0.01%
==========================================
Files 85 85
Lines 13866 13868 +2
==========================================
+ Hits 10851 10852 +1
- Misses 2682 2683 +1
Partials 333 333
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/yunikorn-core/pull/781?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2371] Add failed headroom checks to the allocation log [yunikorn-core]
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #781: [YUNIKORN-2371] Add failed headroom checks to the allocation log
URL: https://github.com/apache/yunikorn-core/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org