[jira] [Commented] (AMBARI-4881) Clean up JMXPropertyProvider hacks for STORM metrics

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-4881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156482#comment-14156482 ] 

Hudson commented on AMBARI-4881:
--------------------------------

SUCCESS: Integrated in Ambari-trunk-Commit #452 (See [https://builds.apache.org/job/Ambari-trunk-Commit/452/])
AMBARI-4881. Clean up JMXPropertyProvider hacks for STORM metrics (aonishuk) (aonishuk: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=cc4dfe351f3ece0082cfbbe4a3657202cf93967b)
* ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsProvider.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
* ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metrics.json
* ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/metrics.json
* ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json
* ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXPropertyProviderTest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsHostProvider.java


> Clean up JMXPropertyProvider hacks for STORM metrics
> ----------------------------------------------------
>
>                 Key: AMBARI-4881
>                 URL: https://issues.apache.org/jira/browse/AMBARI-4881
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server, test
>    Affects Versions: 1.5.0
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>             Fix For: 1.7.0
>
>
> h2. The task
> Clean up a JMXPropertyProvider hacks for STORM metrics
> Also,
> - probably, create a separate provider for rest api 
> - current implementation is only addressing /api/cluster/summary from Storm.  Allow accessing other urls like  /api/supervisors/summary etc
> - When we refactor (assuming using the HttpProxyPropertyProvider), make that be able to take any type of reader.  Also, we want to move to Gson, not Jackson.
> - Is it possible to set the port of the STORM_REST_API component using the UI?  If so, then this will result in a failed query.
> h3. Create RestPropertyProvider
> RestPropertyProvider implementation will be registered at StackDefinedPropertyProvider via reflection ( org.apache.ambari.server.controller.internal.StackDefinedPropertyProvider#getDelegate )
> h3. Add new metrics type "rest" 
> {code}
> {
>   "type": "rest",
>   "properties": {
>      "default_port": "8745" # Storm port is always hardcoded, so we will just use the default value
>      "port_config_type": "storm-site" # Just example, not needed for Storm
>      "port_property_name": "storm.port" # Just example, not needed for Storm
>   }
>   "metrics": {
>     "metrics/api/cluster/summary/nimbus.uptime": {
>       "metric": "api/cluster/summary/nimbus.uptimenimbus.uptime",
>       "pointInTime": true,
>       "temporal": true
>     },
>    ...
> {code}
> Metric group properties define port-related settings. If "port_property" and "relevant_config" keys are defined, provider will try to extract port setting from the service config. Otherwise, provider will use the default port. RestPropertyProvider maintains a cache of per-component port numbers just like we do at org.apache.ambari.server.controller.internal.AbstractProviderModule#getPort
> Metric id "metrics/api/cluster/summary/nimbus.uptime" contains both url and property name. We can not use sole url as metric id because defining few metrics with the same id is not possible.
> h3. Adding to RestPropertyProvider support of nested json properties.
> Given a json file like:
> {code}
> {
>   "a" : "b",
>   "c" : {
>     "d" : "e",
>   }
> }
> {code}
> We may get "e" value by defining metric in form metrics/api/cluster/summary/c#d where "api/cluster/summary" is a json url, and "c#d" points to property "d" nested under property "c". Any nesting depth is supported. Accessing properties inside json value lists is not supported (I don't see any use case for that).
> Going this way, we will be able to access metrics defined at (almost) arbitrary json files at arbitrary ports/urls. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)