You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/08 15:26:34 UTC

[GitHub] [incubator-devlake] likyh opened a new issue, #3329: [Refactor][config-ui] merge board and project in create-blueprint.jsx

likyh opened a new issue, #3329:
URL: https://github.com/apache/incubator-devlake/issues/3329

   ## What and why to refactor
   [What are you trying to refactor? Why should it be refactored now?](https://github.com/apache/incubator-devlake/blob/7b0199a6d8557d4f18b73200d619a96d10df0163/config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx#L66-L73)
   
   board and project have the same logic, and the same usage. So the need to merge into one var.
   `configuredProject` and `configuredBoard`, `activeProject` and `activeBoard` have the same situation.
   
   ## Describe the solution you'd like
   merge board and project into `connectionScopes`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] e2corporation commented on issue #3329: [Refactor][config-ui] merge board and project in create-blueprint.jsx

Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3329:
URL: https://github.com/apache/incubator-devlake/issues/3329#issuecomment-1276522611

   @likyh The Active/Configured Board and Project Entity state vars should be consolidated to either a) `[configuredRecord, setConfiguredRecord]` or b) `[configuredEntity, setConfiguredEntity]` or c) Some naming group better than `a)` or `b)`
   
   By design it's state would be an Instance of any one of the following Data Models that represents a "Board" or "Project" or "Job" or some other future Entity to be treated as the main scope entity.
   
   - `GitlabProject`
   - `GitHubProject`
   - `JiraBoard`
   - `JenkinsJob`
   - `BitbucketProject` (_Future example_ )
   - `AzureJob`  (_Future example_ )
   - `....`
   
   **Entity ID** can easily be obtained by the Model's Accessory method (`gitlabProject.getEntityId()`), since all models will have the base traits required for these model instances.
   ```
   gitlabProject.getEntityId()   // "91837121231"
   ```
   ```
   githubProject.getEntityId() // "merico-dev/lake"
   ```
   
   **Variant** can be used to control business and logic flow based on the varying concept types so UI features can tailored to the differing project concepts.
   ```
   gitlabProject.get('variant')   // "project"
   gitlabProject.variant // "project"
   ```
   ```
   jiraBoard.get('variant')   // "board"
   jiraBoard.variant // "board"
   ```
   ```
   jenkinsJob.get('variant')   // "job"
   jenkinsJob.variant // "job"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh closed issue #3329: [Refactor][config-ui] merge board and project in create-blueprint.jsx

Posted by GitBox <gi...@apache.org>.
likyh closed issue #3329: [Refactor][config-ui] merge board and project in create-blueprint.jsx
URL: https://github.com/apache/incubator-devlake/issues/3329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org