[GitHub] [hadoop] steveloughran commented on a diff in pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

[GitBox <gi...@apache.org>]

steveloughran commented on code in PR #4925:
URL: https://github.com/apache/hadoop/pull/4925#discussion_r977811864


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java:
##########
@@ -79,7 +79,7 @@ protected void patchConfigurationEncryptionSettings(
   };
 
   protected void requireEncryptedFileSystem() {
-    skipIfEncryptionTestsDisabled(getFileSystem().getConf());
+    skipIfEncryptionTestsDisabled(createConfiguration());

Review Comment:
   works as long as there's no looking for any per-bucket property resolution. which is not the case here, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org