You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/04/20 03:11:21 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #35241: GH-35240: [Go][FlightRPC] Fix crash in client middleware
lidavidm opened a new pull request, #35241:
URL: https://github.com/apache/arrow/pull/35241
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
The Go interceptor API includes a provision for errors from trying to start an RPC. The handler for this in the Flight code was trying to use a nil pointer as a result.
### What changes are included in this PR?
Fix a crash when those errors are encountered.
### Are these changes tested?
New tests were added.
### Are there any user-facing changes?
There are no user-facing changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35241: GH-35240: [Go][FlightRPC] Fix crash in client middleware
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35241:
URL: https://github.com/apache/arrow/pull/35241#issuecomment-1518692918
Benchmark runs are scheduled for baseline = 7376b33c03298f273b9120ad83dd05da3d0c3bef and contender = 27066c1f9f6042748ec111df2bf6d8795c3d7d9a. 27066c1f9f6042748ec111df2bf6d8795c3d7d9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1cf9fc29e4ca41fb800e34ef50f4658f...dbb4a259cbab45c28dbedb35f8dac91b/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cb8ab4793cb747918c96a61fc35f285d...2711ee62f1b946a888514e79726cf8fe/)
[Finished :arrow_down:1.28% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4ff7d8075cac4e559cd6e08cdca61b0d...10ba67c2c8d34a30bcccbb4881389ac5/)
[Finished :arrow_down:0.3% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6308a575e2684784ac4e885fefe86eeb...e646e27960f04516933f3f80475ae68e/)
Buildkite builds:
[Finished] [`27066c1f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2762)
[Failed] [`27066c1f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2796)
[Finished] [`27066c1f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2760)
[Finished] [`27066c1f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2787)
[Finished] [`7376b33c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2761)
[Failed] [`7376b33c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2795)
[Finished] [`7376b33c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2759)
[Finished] [`7376b33c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2786)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35241: GH-35240: [Go][FlightRPC] Fix crash in client middleware
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35241:
URL: https://github.com/apache/arrow/pull/35241#issuecomment-1515651040
:warning: GitHub issue #35240 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35241: GH-35240: [Go][FlightRPC] Fix crash in client middleware
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35241:
URL: https://github.com/apache/arrow/pull/35241#issuecomment-1515651016
* Closes: #35240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #35241: GH-35240: [Go][FlightRPC] Fix crash in client middleware
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #35241:
URL: https://github.com/apache/arrow/pull/35241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35241: GH-35240: [Go][FlightRPC] Fix crash in client middleware
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35241:
URL: https://github.com/apache/arrow/pull/35241#issuecomment-1517027426
Looks like the failures are the usual release-time things, unrelated to the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org