[jira] Issue Comment Edited: (THRIFT-953) make check fails in TransportTest.cpp

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921722#action_12921722 ] 

Roger Meier edited comment on THRIFT-953 at 10/16/10 2:05 PM:
--------------------------------------------------------------

I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand/rand is a better alternative and being more POSIX conform is good!

from my perspective, this should be committed!



      was (Author: roger.meier):
    I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand and rand is a good alternative and and beeing more POSIX conform is good!

from my perspective, this should be committed


  
> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.