[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1504: MINIFICPP-1961 Python scripting compatibility with multiple python minor versions

["adamdebreceni (via GitHub)" <gi...@apache.org>]

adamdebreceni commented on code in PR #1504:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1504#discussion_r1107327873


##########
cmake/MiNiFiOptions.cmake:
##########
@@ -102,9 +101,8 @@ add_minifi_option(ENABLE_SQL "Enables the SQL Suite of Tools." ON)
 add_minifi_option(ENABLE_MQTT "Enables the mqtt extension." OFF)
 add_minifi_option(ENABLE_PCAP "Enables the PCAP extension." OFF)
 add_minifi_option(ENABLE_LIBRDKAFKA "Enables the librdkafka extension." ON)
-add_minifi_option(ENABLE_SCRIPTING "Enables the scripting extensions." OFF)
 add_minifi_option(ENABLE_LUA_SCRIPTING "Enables lua scripting" OFF)
-add_minifi_option(DISABLE_PYTHON_SCRIPTING "Disables python scripting" OFF)
+add_minifi_option(ENABLE_PYTHON_SCRIPTING "Enables python scripting" OFF)

Review Comment:
   was changing the default intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org