You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@guacamole.apache.org by "Nick Couchman (JIRA)" <ji...@apache.org> on 2018/12/31 17:35:00 UTC

[jira] [Created] (GUACAMOLE-684) Insufficient Credentials Should Take Precedence over Invalid Credentials

Nick Couchman created GUACAMOLE-684:
---------------------------------------

             Summary: Insufficient Credentials Should Take Precedence over Invalid Credentials
                 Key: GUACAMOLE-684
                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-684
             Project: Guacamole
          Issue Type: Improvement
          Components: guacamole
    Affects Versions: 1.0.0
            Reporter: Nick Couchman
            Assignee: Nick Couchman
             Fix For: 1.0.0


The implementation of several modules that support 2FA/MFA has resulted in some scenarios where "GuacamoleInsufficientCredentialsException" exceptions are override by "GuacamoleInvalidCredentialsException" exceptions.  Due to the way the AuthenticationService class currently handles those exceptions, there is no precedence - the first exception thrown is the one that is returned.  This behavior should be changed such that GuacamoleInsufficientCredentialsException takes precedence over GuacamoleInvalidCredentialsException so that modules requesting additional credentials are not overriden or failed by modules that completely fail authentication.  This will resolve some issues with the order of stacked modules mattering for whether authentication fails or prompts for additional credentials.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)