You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/12/05 09:12:16 UTC

[GitHub] [couchdb] garrensmith commented on a change in pull request #2340: Normalize fabric2 test suite

garrensmith commented on a change in pull request #2340: Normalize fabric2 test suite
URL: https://github.com/apache/couchdb/pull/2340#discussion_r354183464
 
 

 ##########
 File path: src/fabric/test/fabric2_doc_crud_tests.erl
 ##########
 @@ -19,55 +19,58 @@
 -include("fabric2.hrl").
 
 
+-define(TDEF(Name), {atom_to_list(Name), fun Name/1}).
 
 Review comment:
   Could we move this into the couch_eunit.hrl file so we can use it everywhere. And also move the `with` function somewhere so we don't have to keep repeating it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services