You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/08 20:28:36 UTC
[GitHub] gianm commented on issue #6125: Fix appenderator_realtime creating
shards bigger by 1 than maxRowsPerSegment
gianm commented on issue #6125: Fix appenderator_realtime creating shards bigger by 1 than maxRowsPerSegment
URL: https://github.com/apache/incubator-druid/pull/6125#issuecomment-411541340
I don't think it is going to make a huge difference either way. It probably makes sense to do what this patch is doing, i.e., publish when the threshold is _reached_ rather than when it is _exceeded_. It seems more intuitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org