You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mingjie Lai (Created) (JIRA)" <ji...@apache.org> on 2011/10/08 01:55:29 UTC
[jira] [Created] (HBASE-4555) TestShell seems passed, but actually
errors seen in test output file
TestShell seems passed, but actually errors seen in test output file
--------------------------------------------------------------------
Key: HBASE-4555
URL: https://issues.apache.org/jira/browse/HBASE-4555
Project: HBase
Issue Type: Test
Components: test
Reporter: Mingjie Lai
When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
{code}
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.client.TestShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}
Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
{code}
...
6) Error:
test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
ArgumentError: There should be at least one argument but the table name
/home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
org/jruby/RubyProc.java:268:in `call'
org/jruby/RubyKernel.java:2038:in `send'
org/jruby/RubyArray.java:1572:in `each'
org/jruby/RubyArray.java:1572:in `each'
7) Error:
test_split_should_work(Hbase::AdminMethodsTest):
ArgumentError: wrong number of arguments (1 for 2)
./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
org/jruby/RubyProc.java:268:in `call'
org/jruby/RubyKernel.java:2038:in `send'
org/jruby/RubyArray.java:1572:in `each'
org/jruby/RubyArray.java:1572:in `each'
192 tests, 259 assertions, 1 failures, 6 errors
Done with tests! Shutting down the cluster...
2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Mingjie Lai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125554#comment-13125554 ]
Mingjie Lai commented on HBASE-4555:
------------------------------------
Final patch attached. Thanks.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff, HBase-4555-trunk-0.92.patch
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4555) TestShell seems passed, but actually
errors seen in test output file
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-4555:
-------------------------------
Attachment: HBase-4555-trunk-0.92.patch
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff, HBase-4555-trunk-0.92.patch
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126236#comment-13126236 ]
Hudson commented on HBASE-4555:
-------------------------------
Integrated in HBase-0.92 #58 (See [https://builds.apache.org/job/HBase-0.92/58/])
HBASE-4555 TestShell seems passed, but actually errors seen in test output file
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/test/ruby/hbase/admin_test.rb
* /hbase/branches/0.92/src/test/ruby/tests_runner.rb
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
> Attachments: 4555.diff, HBase-4555-trunk-0.92.patch
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126150#comment-13126150 ]
Hudson commented on HBASE-4555:
-------------------------------
Integrated in HBase-TRUNK #2321 (See [https://builds.apache.org/job/HBase-TRUNK/2321/])
HBASE-4555 TestShell seems passed, but actually errors seen in test output file
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/ruby/hbase/admin_test.rb
* /hbase/trunk/src/test/ruby/tests_runner.rb
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
> Attachments: 4555.diff, HBase-4555-trunk-0.92.patch
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125491#comment-13125491 ]
jiraposter@reviews.apache.org commented on HBASE-4555:
------------------------------------------------------
bq. On 2011-10-11 23:50:18, Michael Stack wrote:
bq. >
Mind adding this patch to JIRA so I can apply it Mingjie (You need to add it because you need to click the "Grant license to ASF for inclusion in ASF works (as per the Apache License ยง5)" button since you wrote the patch. Good stuff.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2351/#review2521
-----------------------------------------------------------
On 2011-10-11 23:02:27, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2351/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 23:02:27)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBase shell unit cases are in ruby. Ruby unit test runner Test::Unit::AutoRunner.run only prints unit tests assertion failures to console by default. So it actually swallows all the assertion errors from ruby, and junit cannot notice any shell test failure.
bq.
bq. Fixed the test_runner.rb to chech the return value and throw a runtime exception, so that TestShell can get to know there is something wrong by test errors.
bq.
bq. Also fixed 7 previously existing failed test cases.
bq.
bq. In addition, after HBase-1730, there's no need to disable a table before altering a table. Changed the test cases accordingly.
bq.
bq.
bq. This addresses bug HBase-4555.
bq. https://issues.apache.org/jira/browse/HBase-4555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/ruby/hbase/admin_test.rb 5e491e4
bq. src/test/ruby/tests_runner.rb 0dbc5ce
bq.
bq. Diff: https://reviews.apache.org/r/2351/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestShell passed locally.
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4555) TestShell seems passed, but actually
errors seen in test output file
Posted by "Mingjie Lai (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai reassigned HBASE-4555:
----------------------------------
Assignee: Mingjie Lai
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4555) TestShell seems passed, but actually
errors seen in test output file
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4555.
--------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: Reviewed
Committed to 0.92 and TRUNK. Thank you for the patch Mingjie.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
> Attachments: 4555.diff, HBase-4555-trunk-0.92.patch
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124770#comment-13124770 ]
Ted Yu commented on HBASE-4555:
-------------------------------
Thanks for the finding, Mingjie.
I am afraid the symptom for builds 2314 and beyond is different.
We'd better reproduce the hanging TestShell and see where it gets stuck.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124739#comment-13124739 ]
Ted Yu commented on HBASE-4555:
-------------------------------
Interesting.
Next step would be fixing the failures now that TestShell consistently hangs on Jenkins.
Actually I don't see its output file here:
https://builds.apache.org/view/G-L/view/HBase/job/HBase-TRUNK/2314/artifact/trunk/target/surefire-reports/
and org.apache.hadoop.hbase.client.TestShell.txt is empty :-(
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4555) TestShell seems passed, but actually
errors seen in test output file
Posted by "Mingjie Lai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-4555:
-------------------------------
Attachment: 4555.diff
Patch 1.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Mingjie Lai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124774#comment-13124774 ]
Mingjie Lai commented on HBASE-4555:
------------------------------------
I agree. Hanging TestShell should be another issue. This one is about discovering hidden TestShell assertion failures.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Mingjie Lai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124729#comment-13124729 ]
Mingjie Lai commented on HBASE-4555:
------------------------------------
HBase shell unit cases are in ruby. Ruby unit test runner Test::Unit::AutoRunner.run only prints unit tests assertion failures to console by default. So it actually swallows all the assertion errors from ruby, and junit cannot notice any shell test failure.
I checked the source code of Test::Unit::AutoRunner.run, and it returns a boolean to indicate test result successfully or not. The attached patch just checks the return value and throw a runtime exception so TestShell can get to know there is something wrong by test errors. The drawback is that we won't see detailed failure info unless we check the output file.
{code}
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.client.TestShell
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 52.802 sec <<< FAILURE!
Results :
Tests in error:
testRunShellTests(org.apache.hadoop.hbase.client.TestShell): (RuntimeError) Shell unit tests failed. Check output file for details.
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
{code}
The perfect solution would be that ruby unit tests can pass test results to junit, so junit can display failures nicely.
After the patch, we will see TestShell failures we've never seen. And they need to be fixed.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "Mingjie Lai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124759#comment-13124759 ]
Mingjie Lai commented on HBASE-4555:
------------------------------------
@ted. I checked an earlier build 2310 and you can see the errors:
https://builds.apache.org/view/G-L/view/HBase/job/HBase-TRUNK/2310/artifact/trunk/target/surefire-reports/org.apache.hadoop.hbase.client.TestShell-output.txt
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125487#comment-13125487 ]
jiraposter@reviews.apache.org commented on HBASE-4555:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2351/#review2521
-----------------------------------------------------------
Ship it!
- Michael
On 2011-10-11 23:02:27, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2351/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 23:02:27)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBase shell unit cases are in ruby. Ruby unit test runner Test::Unit::AutoRunner.run only prints unit tests assertion failures to console by default. So it actually swallows all the assertion errors from ruby, and junit cannot notice any shell test failure.
bq.
bq. Fixed the test_runner.rb to chech the return value and throw a runtime exception, so that TestShell can get to know there is something wrong by test errors.
bq.
bq. Also fixed 7 previously existing failed test cases.
bq.
bq. In addition, after HBase-1730, there's no need to disable a table before altering a table. Changed the test cases accordingly.
bq.
bq.
bq. This addresses bug HBase-4555.
bq. https://issues.apache.org/jira/browse/HBase-4555
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/ruby/hbase/admin_test.rb 5e491e4
bq. src/test/ruby/tests_runner.rb 0dbc5ce
bq.
bq. Diff: https://reviews.apache.org/r/2351/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestShell passed locally.
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4555) TestShell seems passed, but
actually errors seen in test output file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125466#comment-13125466 ]
jiraposter@reviews.apache.org commented on HBASE-4555:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2351/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
HBase shell unit cases are in ruby. Ruby unit test runner Test::Unit::AutoRunner.run only prints unit tests assertion failures to console by default. So it actually swallows all the assertion errors from ruby, and junit cannot notice any shell test failure.
Fixed the test_runner.rb to chech the return value and throw a runtime exception, so that TestShell can get to know there is something wrong by test errors.
Also fixed 7 previously existing failed test cases.
In addition, after HBase-1730, there's no need to disable a table before altering a table. Changed the test cases accordingly.
This addresses bug HBase-4555.
https://issues.apache.org/jira/browse/HBase-4555
Diffs
-----
src/test/ruby/hbase/admin_test.rb 5e491e4
src/test/ruby/tests_runner.rb 0dbc5ce
Diff: https://reviews.apache.org/r/2351/diff
Testing
-------
TestShell passed locally.
Thanks,
Mingjie
> TestShell seems passed, but actually errors seen in test output file
> --------------------------------------------------------------------
>
> Key: HBASE-4555
> URL: https://issues.apache.org/jira/browse/HBASE-4555
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: 4555.diff
>
>
> When I was making test cases for 4554, I saw a weird issue that TestShell seems to pass, but actually I saw error messages in the output file.
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hbase.client.TestShell
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
> Results :
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> {code}
> Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
> {code}
> ...
> 6) Error:
> test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
> ArgumentError: There should be at least one argument but the table name
> /home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in `alter'
> ./src/test/ruby/hbase/admin_test.rb:271:in `test_alter_should_support_shortcut_DELETE_alter_specs'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 7) Error:
> test_split_should_work(Hbase::AdminMethodsTest):
> ArgumentError: wrong number of arguments (1 for 2)
> ./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
> org/jruby/RubyProc.java:268:in `call'
> org/jruby/RubyKernel.java:2038:in `send'
> org/jruby/RubyArray.java:1572:in `each'
> org/jruby/RubyArray.java:1572:in `each'
>
> 192 tests, 259 assertions, 1 failures, 6 errors
> Done with tests! Shutting down the cluster...
> 2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting down minicluster
> 2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down HBase Cluster
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira