You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/07 01:32:00 UTC
[jira] [Commented] (AMBARI-25012) Log Search UI: cannot save
filters + select all selecting the ovirrides as well
[ https://issues.apache.org/jira/browse/AMBARI-25012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712222#comment-16712222 ]
ASF GitHub Bot commented on AMBARI-25012:
-----------------------------------------
tobias-istvan opened a new pull request #57: [AMBARI-25012] Log Search UI: cannot save filters + select all selecting the ovirrides as well
URL: https://github.com/apache/ambari-logsearch/pull/57
# What changes were proposed in this pull request?
Save button state: Changing the enable/disable condition to a more direct one.
Overrides checking with "select all": checking the component hasOverrides prop too.
## How was this patch tested?
It was tested manually and by unit tests:
```
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 295 of 295 SUCCESS (11.208 secs / 11.037 secs)
✨ Done in 40.82s.
```
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Log Search UI: cannot save filters + select all selecting the ovirrides as well
> -------------------------------------------------------------------------------
>
> Key: AMBARI-25012
> URL: https://issues.apache.org/jira/browse/AMBARI-25012
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-logsearch, logsearch
> Affects Versions: 2.7.3
> Reporter: Istvan Tobias
> Assignee: Istvan Tobias
> Priority: Blocker
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Clicking out a log level from debug to nothing, save button was still disabled.
> Also clicking select all selected the overrides rows as well (as no hostname set there or anything, not sure what is expected there, hopefully we would not save that with filled empty hostname but with one debug log level)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)