You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/12 17:00:14 UTC

[GitHub] [incubator-kvrocks] torwig commented on pull request #1106: Fix performance-unnecessary-value-param warning reported by clang-tidy

torwig commented on PR #1106:
URL: https://github.com/apache/incubator-kvrocks/pull/1106#issuecomment-1312527483

   @tanruixiang I think such code fixes aren't similar to formatting and are able to change program behavior, so probably it's better to fix them manually, double-checking every case. Even if, in 99.99% of cases, the 'auto-fix' will do the right thing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org