You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/28 19:27:21 UTC

[GitHub] [spark] imback82 commented on a change in pull request #34726: [SPARK-33875][SQL][FOLLOWUP] Handle the char/varchar column for `Describe column` command

imback82 commented on a change in pull request #34726:
URL: https://github.com/apache/spark/pull/34726#discussion_r757939914



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -158,7 +158,8 @@ class DataSourceV2SQLSuite
   test("Describe column for v2 catalog") {
     val t = "testcat.tbl"
     withTable(t) {
-      sql(s"CREATE TABLE $t (id bigint, data string COMMENT 'hello') USING foo")
+      sql(s"CREATE TABLE $t (id bigint, data string COMMENT 'hello'," +
+        s" user char(10), country varchar(20)) USING foo")

Review comment:
       nit: `s` not needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org