You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/05 05:09:10 UTC
[GitHub] [calcite] geetha-rangaswamaiah opened a new pull request #2245: Fix grammatical errors
geetha-rangaswamaiah opened a new pull request #2245:
URL: https://github.com/apache/calcite/pull/2245
This PR fixes grammatical errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] geetha-rangaswamaiah commented on a change in pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
geetha-rangaswamaiah commented on a change in pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#discussion_r518077520
##########
File path: site/_docs/adapter.md
##########
@@ -236,7 +236,7 @@ They are straightforward to write (you just write a Java class and register it
in your schema) but do not offer much flexibility in the number and type of
arguments, resolving overloaded functions, or deriving the return type.
-It you want that flexibility, you probably need to write you a
+If you want that flexibility, you probably need to write you a
Review comment:
Right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#issuecomment-723010780
Thanks for the PR @geetha-rangaswamaiah , I have no further comments.
If you could please squash all commits into a single one, I'll proceed with the merge. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada merged pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
rubenada merged pull request #2245:
URL: https://github.com/apache/calcite/pull/2245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] geetha-rangaswamaiah commented on a change in pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
geetha-rangaswamaiah commented on a change in pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#discussion_r518640579
##########
File path: site/_docs/algebra.md
##########
@@ -37,7 +37,7 @@ planner engine generates an alternative expression that has the same
semantics as the original but a lower cost.
The planning process is extensible. You can add your own relational
-operators, planner rules, cost model, and statistics.
+operators, planner rules, cost models, and statistics.
Review comment:
Reverted back. https://github.com/apache/calcite/pull/2245/commits/8295c062503f89eef6368c6849eaea2a73b8cf95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#issuecomment-724043388
Thanks @geetha-rangaswamaiah for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on a change in pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
rubenada commented on a change in pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#discussion_r517903480
##########
File path: site/_docs/adapter.md
##########
@@ -236,7 +236,7 @@ They are straightforward to write (you just write a Java class and register it
in your schema) but do not offer much flexibility in the number and type of
arguments, resolving overloaded functions, or deriving the return type.
-It you want that flexibility, you probably need to write you a
+If you want that flexibility, you probably need to write you a
Review comment:
Shouldn't we change the second part of the sentence too?
```
you probably need to write you a *user-defined operator*
=>
you probably need to write a *user-defined operator*
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#issuecomment-723869181
@geetha-rangaswamaiah a final detail: could you please adjust the commit message to have a simple one; and also please add your name in parentheses at the end of the message (see https://calcite.apache.org/develop/#contributing), e.g. "Fix grammatical errors in documentation (name)"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on a change in pull request #2245: Fix grammatical errors
Posted by GitBox <gi...@apache.org>.
rubenada commented on a change in pull request #2245:
URL: https://github.com/apache/calcite/pull/2245#discussion_r518615633
##########
File path: site/_docs/algebra.md
##########
@@ -37,7 +37,7 @@ planner engine generates an alternative expression that has the same
semantics as the original but a lower cost.
The planning process is extensible. You can add your own relational
-operators, planner rules, cost model, and statistics.
+operators, planner rules, cost models, and statistics.
Review comment:
minor remark: I think the original one (in singular) was arguably more accurate, since the cost model is a single one in the whole process (as described in the previous paragraph). So, I'd lean towards leaving this sentence as it was.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org