You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/08 19:16:46 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7609: Prevent host Vulkan SDK blocking cross-compilation

tqchen commented on a change in pull request #7609:
URL: https://github.com/apache/tvm/pull/7609#discussion_r589681818



##########
File path: cmake/modules/Vulkan.cmake
##########
@@ -26,13 +26,8 @@ IF USE_VULKAN)
 tvm_option(USE_VULKAN_VALIDATION "Enable Vulkan API validation layers" OFF
   IF USE_VULKAN)
 
-if(Vulkan_FOUND)
-  # always set the includedir
-  # avoid global retrigger of cmake
-  include_directories(SYSTEM ${Vulkan_INCLUDE_DIRS})
-endif(Vulkan_FOUND)
-
 if(USE_VULKAN)
+  include_directories(SYSTEM ${Vulkan_INCLUDE_DIRS})

Review comment:
       move it to after the end of the if statement below




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org