[jira] [Resolved] (TS-162) inconsistencies in the stats system - there are incorrect assumtions on sychronization between threads

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom resolved TS-162.
------------------------------

    Resolution: Won't Fix

Closing, since we won't be making any further 2.0.x releases.

> inconsistencies in the stats system - there are incorrect assumtions on sychronization between threads
> ------------------------------------------------------------------------------------------------------
>
>                 Key: TS-162
>                 URL: https://issues.apache.org/jira/browse/TS-162
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Stats
>            Reporter: Bryan Call
>            Assignee: Bryan Call
>             Fix For: 2.0.2
>
>         Attachments: stats_bcall_001.diff, stats_bcall_002.diff
>
>
> There is a problem with the current stats being inconsistent.  The problem is that the net threads each have their own stats which they modify and the aggregation thread also modifies the same stat value.  There is no proper synchronization for this to work correctly.  The aggregation thread does an atomic swap to zero the net threads stat value, but the local thread doesn't use atomics and only increments the value.  This will lead to inconsistencies...
> A better design is to *only* have the net threads modify their local stats and have the aggregation thread handle totalling the values in a separate stat structure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira