You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "yevgenypats (via GitHub)" <gi...@apache.org> on 2023/04/19 08:21:20 UTC

[GitHub] [arrow] yevgenypats opened a new issue, #35232: [Go] [Question]: Retain/Release benchmarks vs Go garbage collection

yevgenypats opened a new issue, #35232:
URL: https://github.com/apache/arrow/issues/35232

   ### Describe the enhancement requested
   
   Hi! Im curious if a benchmark was ever done around the value of Retain/Release in the Go library vs not having it at all and getting the garbage collection taking care of that. Maybe we should have a mode where `Retain`/`Release` is not necessary? Or there is other reason Im not aware of?
   
   cc @zeroshade 
   
   ### Component(s)
   
   Go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade commented on issue #35232: [Go] [Question]: Retain/Release benchmarks vs Go garbage collection

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #35232:
URL: https://github.com/apache/arrow/issues/35232#issuecomment-1514914698

   To my knowledge I don't believe a benchmark has actually been done around it as those predate the original donation of the code from InfluxDB to the repository.
   
   In theory, if you *know* you're using the default Go allocator, you don't actually have to call `Retain`/`Release` in your consumer code and can just let the Go garbage collector manage everything. We just need to make sure that we're calling `Retain`/`Release` internally here in the library so that *if* a consumer is using a non-Go-GC allocator we can be sure that they won't end up with memory leaks.
   
   The primary reasons for their existence currently are:
   * Allowing the user to control when buffers and internals are set to nil to be marked for garbage collection early if possible
   * Allowing for proper usage of allocators that don't rely on the Go garbage collector (such as the `mallocator` impl which uses malloc/free to manage C memory instead of Go garbage collection) if a user desires. 
   * While a finalizer could be utilized via `SetFinalizer` the general advice is that it's better to have an explicit release rather than relying on a finalizer since there's no actual guarantee that finalizers will ever run. In addition, finalizers only run during GC, which means that if your allocator is allocating C memory or something and the Go memory stays low it's possible that you'll end up with a ton of C memory allocated blowing out your memory before any finalizers run to actually call free on things. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] yevgenypats commented on issue #35232: [Go] [Question]: Retain/Release benchmarks vs Go garbage collection

Posted by "yevgenypats (via GitHub)" <gi...@apache.org>.
yevgenypats commented on issue #35232:
URL: https://github.com/apache/arrow/issues/35232#issuecomment-1515179918

   Got it. Ok that makes tons of sense. Thanks for the explanation. Going to close it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] yevgenypats closed issue #35232: [Go] [Question]: Retain/Release benchmarks vs Go garbage collection

Posted by "yevgenypats (via GitHub)" <gi...@apache.org>.
yevgenypats closed issue #35232: [Go] [Question]: Retain/Release benchmarks vs Go garbage collection
URL: https://github.com/apache/arrow/issues/35232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org