[GitHub] [helix] NealSun96 commented on a change in pull request #915: Make multiZkEnabled configurable in HelixRestNamespace

[GitBox <gi...@apache.org>]

NealSun96 commented on a change in pull request #915: Make multiZkEnabled configurable in HelixRestNamespace
URL: https://github.com/apache/helix/pull/915#discussion_r398940552
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java
 ##########
 @@ -111,20 +114,9 @@ public RealmAwareZkClient getRealmAwareZkClient() {
       synchronized (this) {
         if (_zkClient == null) {
           // If the multi ZK config is enabled, use FederatedZkClient on multi-realm mode
-          if (Boolean.parseBoolean(System.getProperty(SystemPropertyKeys.MULTI_ZK_ENABLED))) {
-            LOG.info("ServerContext: initializing FederatedZkClient with routing ZK at {}!",
-                _zkAddr);
+          if (_isMultiZkEnabled || Boolean
+              .parseBoolean(System.getProperty(SystemPropertyKeys.MULTI_ZK_ENABLED))) {
 
 Review comment:
   Aren't we moving away from system properties? 
   If we allow both it could be confusing, unless we specifically document for it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org