You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/05/02 00:36:49 UTC

[GitHub] [druid] gulinfu opened a new pull request #9805: Update zookeeper.md

gulinfu opened a new pull request #9805:
URL: https://github.com/apache/druid/pull/9805


   Add information about zookeeper Znode size config.
   
   <!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
   
   Fixes #XXXX.
   
   <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
   
   <!-- If you are a committer, follow the PR action item checklist for committers:
   https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
   
   ### Description
   
   <!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
   
   <!-- Describe your patch: what did you change in code? How did you fix the problem? -->
   
   <!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
   
   #### Fixed the bug ...
   #### Renamed the class ...
   #### Added a forbidden-apis entry ...
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
    - Method organization and design (how the logic is split between methods, parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [y ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [n ] added unit tests or modified existing tests to cover new code paths.
   - [n ] added integration tests.
   - [n ] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * Update zookeeper doc
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] stale[bot] closed pull request #9805: Update zookeeper.md

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9805:
URL: https://github.com/apache/druid/pull/9805


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] stale[bot] commented on pull request #9805: Update zookeeper.md

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9805:
URL: https://github.com/apache/druid/pull/9805#issuecomment-685309611


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] yuanlihan commented on pull request #9805: Update zookeeper.md

Posted by GitBox <gi...@apache.org>.
yuanlihan commented on pull request #9805:
URL: https://github.com/apache/druid/pull/9805#issuecomment-626269243


   Hi @gulinfu, first I like this diff and think it's very helpful to quickly handle the `Packet len is out of range!` error.
   
   Actually, I have encountered this issue before and solved it by adjusting `jute.maxbuffer`. But I thought it's a bug after looked into the source code for a while. I found that Druid itself does intend to not exceed the default limit of `jute.maxbuffer` but may fail to do that in some cases. See `BatchDataSegmentAnnouncer`, `BatchDataSegmentAnnouncerConfig`, and etc. Hoping to hear your thoughts on this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] stale[bot] commented on pull request #9805: Update zookeeper.md

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9805:
URL: https://github.com/apache/druid/pull/9805#issuecomment-703191274


   This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis commented on a change in pull request #9805: Update zookeeper.md

Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9805:
URL: https://github.com/apache/druid/pull/9805#discussion_r449714132



##########
File path: docs/dependencies/zookeeper.md
##########
@@ -74,3 +74,22 @@ ${druid.zk.paths.loadQueuePath}/_host_of_historical_process/_segment_identifier
 ```
 
 This znode will contain a payload that indicates to the Historical process what it should do with the given segment. When the Historical process is done with the work, it will delete the znode in order to signify to the Coordinator that it is complete.
+
+## Common zookeeper related config
+
+### Znode size limit
+When dealing with large data volumn and a lot of segments, errors can be caused due to Znode size limit exceeded.

Review comment:
       ```suggestion
   When dealing with large data volume and a lot of segments, errors can be caused due to Znode size limit exceeded.
   ```

##########
File path: docs/dependencies/zookeeper.md
##########
@@ -74,3 +74,22 @@ ${druid.zk.paths.loadQueuePath}/_host_of_historical_process/_segment_identifier
 ```
 
 This znode will contain a payload that indicates to the Historical process what it should do with the given segment. When the Historical process is done with the work, it will delete the znode in order to signify to the Coordinator that it is complete.
+
+## Common zookeeper related config
+
+### Znode size limit
+When dealing with large data volumn and a lot of segments, errors can be caused due to Znode size limit exceeded.
+There are at least 3 places the znode size can be configured:
+- Druid nodes runtime property:
+`druid.indexer.runner.maxZnodeBytes` works as druid internal znode limit on middleManagers and overlods.

Review comment:
       ```suggestion
   `druid.indexer.runner.maxZnodeBytes` works as Druid internal znode limit on MiddleManagers, Indexers, and Overlords.
   ```

##########
File path: docs/dependencies/zookeeper.md
##########
@@ -74,3 +74,22 @@ ${druid.zk.paths.loadQueuePath}/_host_of_historical_process/_segment_identifier
 ```
 
 This znode will contain a payload that indicates to the Historical process what it should do with the given segment. When the Historical process is done with the work, it will delete the znode in order to signify to the Coordinator that it is complete.
+
+## Common zookeeper related config
+
+### Znode size limit
+When dealing with large data volumn and a lot of segments, errors can be caused due to Znode size limit exceeded.
+There are at least 3 places the znode size can be configured:
+- Druid nodes runtime property:
+`druid.indexer.runner.maxZnodeBytes` works as druid internal znode limit on middleManagers and overlods.
+
+- Zookeeper client side config:
+`jute.maxbuffer` Java system property works as a zookeeper client side limit on druid nodes.
+
+- Zookeeper server side config:
+`jute.maxbuffer` Java system property works as a zookeeper server side limit on your zookeeper cluster.

Review comment:
       ```suggestion
   `jute.maxbuffer` Java system property works as a ZooKeeper server side limit on your ZooKeeper cluster.
   ```

##########
File path: docs/dependencies/zookeeper.md
##########
@@ -74,3 +74,22 @@ ${druid.zk.paths.loadQueuePath}/_host_of_historical_process/_segment_identifier
 ```
 
 This znode will contain a payload that indicates to the Historical process what it should do with the given segment. When the Historical process is done with the work, it will delete the znode in order to signify to the Coordinator that it is complete.
+
+## Common zookeeper related config
+
+### Znode size limit
+When dealing with large data volumn and a lot of segments, errors can be caused due to Znode size limit exceeded.
+There are at least 3 places the znode size can be configured:
+- Druid nodes runtime property:
+`druid.indexer.runner.maxZnodeBytes` works as druid internal znode limit on middleManagers and overlods.
+
+- Zookeeper client side config:
+`jute.maxbuffer` Java system property works as a zookeeper client side limit on druid nodes.

Review comment:
       ```suggestion
   `jute.maxbuffer` Java system property that works as a ZooKeeper client side limit on Druid nodes.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org