You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by no...@apache.org on 2015/05/13 16:53:04 UTC

svn commit: r1679221 - in /lucene/dev/trunk/solr: CHANGES.txt core/src/java/org/apache/solr/core/SolrConfig.java core/src/java/org/apache/solr/handler/SolrConfigHandler.java

Author: noble
Date: Wed May 13 14:53:03 2015
New Revision: 1679221

URL: http://svn.apache.org/r1679221
Log:
SOLR-7531: config API shows a few keys merged together

Modified:
    lucene/dev/trunk/solr/CHANGES.txt
    lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrConfig.java
    lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java

Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1679221&r1=1679220&r2=1679221&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Wed May 13 14:53:03 2015
@@ -257,6 +257,8 @@ Bug Fixes
 
 * SOLR-7514: SolrClient.getByIds fails with ClassCastException (Tom Farnworth, Ramkumar Aiyengar)
 
+* SOLR-7531: config API shows a few keys merged together (Noble Paul)
+
 Optimizations
 ----------------------
 

Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrConfig.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrConfig.java?rev=1679221&r1=1679220&r2=1679221&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrConfig.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrConfig.java Wed May 13 14:53:03 2015
@@ -80,6 +80,7 @@ import org.w3c.dom.NodeList;
 import org.xml.sax.InputSource;
 import org.xml.sax.SAXException;
 
+import static org.apache.solr.common.cloud.ZkNodeProps.makeMap;
 import static org.apache.solr.common.params.CommonParams.NAME;
 import static org.apache.solr.common.params.CommonParams.PATH;
 import static org.apache.solr.core.ConfigOverlay.ZNODEVER;
@@ -550,7 +551,7 @@ public class SolrConfig extends Config i
 
     @Override
     public Map<String, Object> toMap() {
-      return ZkNodeProps.makeMap("never304", never304,
+      return makeMap("never304", never304,
           "etagSeed", etagSeed,
           "lastModFrom", lastModFrom.name().toLowerCase(Locale.ROOT),
           "cacheControl", cacheControlHeader);
@@ -667,19 +668,17 @@ public class SolrConfig extends Config i
     @Override
     public Map<String, Object> toMap() {
       LinkedHashMap result = new LinkedHashMap();
-      result.put("class", className);
-      result.put("autoCommmitMaxDocs", autoCommmitMaxDocs);
-      result.put("indexWriterCloseWaitsForMerges", indexWriterCloseWaitsForMerges);
+      result.put("indexWriter", makeMap("closeWaitsForMerges", indexWriterCloseWaitsForMerges));
       result.put("openSearcher", openSearcher);
       result.put("commitIntervalLowerBound", commitIntervalLowerBound);
-      result.put("commitWithinSoftCommit", commitWithinSoftCommit);
-      result.put("autoCommit", ZkNodeProps.makeMap(
+      result.put("commitWithin", makeMap("softCommit", commitWithinSoftCommit));
+      result.put("autoCommit", makeMap(
           "maxDocs", autoCommmitMaxDocs,
           "maxTime", autoCommmitMaxTime,
           "commitIntervalLowerBound", commitIntervalLowerBound
       ));
       result.put("autoSoftCommit",
-          ZkNodeProps.makeMap("maxDocs", autoSoftCommmitMaxDocs,
+          makeMap("maxDocs", autoSoftCommmitMaxDocs,
               "maxTime", autoSoftCommmitMaxTime));
       return result;
     }
@@ -872,7 +871,7 @@ public class SolrConfig extends Config i
     result.put("requestDispatcher", m);
     m.put("handleSelect", handleSelect);
     if (httpCachingConfig != null) m.put("httpCaching", httpCachingConfig.toMap());
-    m.put("requestParsers", ZkNodeProps.makeMap("multipartUploadLimitKB", multipartUploadLimitKB,
+    m.put("requestParsers", makeMap("multipartUploadLimitKB", multipartUploadLimitKB,
         "formUploadLimitKB", formUploadLimitKB,
         "addHttpRequestToContext", addHttpRequestToContext));
     if (indexConfig != null) result.put("indexConfig", indexConfig.toMap());

Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java?rev=1679221&r1=1679220&r2=1679221&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SolrConfigHandler.java Wed May 13 14:53:03 2015
@@ -599,7 +599,7 @@ public class SolrConfigHandler extends R
   }
 
 
-  private static Set<String> subPaths = new HashSet<>(Arrays.asList("/overlay", "/params",
+  private static Set<String> subPaths = new HashSet<>(Arrays.asList("/overlay", "/params", "/updateHandler",
       "/query", "/jmx", "/requestDispatcher", "/znodeVersion"));
 
   static {