You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2020/07/01 14:24:00 UTC

[jira] [Comment Edited] (MNG-6951) Failing integration test MNG-6386 (Unicode chars) on macOS

    [ https://issues.apache.org/jira/browse/MNG-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149474#comment-17149474 ] 

Michael Osipov edited comment on MNG-6951 at 7/1/20, 2:23 PM:
--------------------------------------------------------------

OK, it is the reason I assumed to be. Yet another annoyance on macOS: decomposition. The behavior has [changed with APFS|https://eclecticlight.co/2017/04/06/apfs-is-currently-unusable-with-most-non-english-languages/], but not really better. We have [this|http://www.fileformat.info/info/unicode/char/0439/index.htm] letter which is stored in decomposed form on the FS (last four bytes). Can you set [{{core.precomposeunicode}}|https://gitlab.cecs.anu.edu.au/comp8440/git/commit/76759c7dff53e8c84e975b88cb8245587c14c7ba] globally and reclone? Moreover, create a file manually with the same name and see what the {{Path#toUri()#toASCIIString()}} gives you. If I understand docs correcty, it will be composed. If everything else fails we need an if clause for NFD crap on macOS. This is is an issue Subversion developers have been fighting with for at least ten years and Apple didn't improve anything with APFS.


was (Author: michael-o):
OK, it is the reason I assumed to be. Yet another annoyance on macOS: decomposition. The behavior has [changed with APFS|https://eclecticlight.co/2017/04/06/apfs-is-currently-unusable-with-most-non-english-languages/], but not really better. We have [this|http://www.fileformat.info/info/unicode/char/0439/index.htm] letter which is stored in decomposed form on the FS (last four bytes). Can you set {{core.precomposeunicode}} globally and reclone? Moreover, create a file manually with the same name and see what the {{Path#toUri()#toASCIIString()}} gives you. If I understand docs correcty, it will be composed. If everything else fails we need an if clause for NFD crap on macOS. This is is an issue Subversion developers have been fighting with for at least ten years and Apple didn't improve anything with APFS.

> Failing integration test MNG-6386 (Unicode chars) on macOS
> ----------------------------------------------------------
>
>                 Key: MNG-6951
>                 URL: https://issues.apache.org/jira/browse/MNG-6951
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>         Environment: macOS
>            Reporter: Maarten Mulders
>            Priority: Minor
>         Attachments: Screenshot 2020-07-01 at 15.28.33.png, log-basic.txt, profile.properties
>
>
> Ever since I started contributing on Maven, I noticed that there's one integration test that fails on my machine (a Macbook). The test is located in the {{MavenITmng6386BaseUriPropertyTest}} class, more specifically the {{testitMNG6386UnicodeChars}} method.
> I always thought it would be "just" my machine but in the last week, two things happened.
>  # I reinstalled macOS on my machine. Unfortunately, the test still fails on the freshly installed macOS.
>  # Together with [~MartinKanters], I started experimenting with GitHub actions, which also provides free macOS builds. The test also fails on those machines.
> I've tried to debug why the test fails. The assertion that fails is the last one, which checks for some Russian text in a property. But I don't understand the reason for the failure.
> The {{mng-6386-это по-русский}} folder gets checked out by Git on APFS using the expected filename, as you can see in the attached screenshot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)