You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2021/05/31 06:38:01 UTC
[incubator-nuttx] 01/05: psock_tcp_recvfrom: Add a comment about
window updates
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0c606ecb8e0048840639f52bc7268e8b63ada2bd
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:02:42 2021 +0900
psock_tcp_recvfrom: Add a comment about window updates
---
net/tcp/tcp_recvfrom.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/tcp/tcp_recvfrom.c b/net/tcp/tcp_recvfrom.c
index 1d11d76..973a5c5 100644
--- a/net/tcp/tcp_recvfrom.c
+++ b/net/tcp/tcp_recvfrom.c
@@ -809,7 +809,12 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR void *buf,
}
}
- /* Receive additional data from read-ahead buffer, send the ACK timely. */
+ /* Receive additional data from read-ahead buffer, send the ACK timely.
+ *
+ * Revisit: Because IOBs are system-wide resources, consuming the read
+ * ahead buffer would update recv window of all connections in the system,
+ * not only this particular connection.
+ */
if (conn->rcv_wnd == 0 && conn->rcv_ackcb == NULL)
{