You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/16 12:41:38 UTC
[GitHub] [nuttx] Donny9 opened a new pull request, #8139: [PATCH2]mm/backtrace: add backtrace for mempool and memdup for tlsf
Donny9 opened a new pull request, #8139:
URL: https://github.com/apache/nuttx/pull/8139
## Summary
This patch is a part #8131
1. add backtrace info for mempool.
2. support memdump for tlsf manager.
3. fix minor issue about mm backtrace.
## Impact
support backtrace for mempool and tlsf.
## Testing
Vela CI test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8139: [PATCH2]mm/backtrace: add backtrace for mempool and memdup for tlsf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8139:
URL: https://github.com/apache/nuttx/pull/8139#discussion_r1071700970
##########
mm/mempool/mempool.c:
##########
@@ -22,13 +22,41 @@
* Included Files
****************************************************************************/
+#include <execinfo.h>
#include <stdbool.h>
+#include <stdio.h>
+#include <syslog.h>
#include <nuttx/kmalloc.h>
#include <nuttx/mm/mempool.h>
#include "kasan/kasan.h"
+#if UINTPTR_MAX <= UINT32_MAX
+# define MM_PTR_FMT_WIDTH 11
+#elif UINTPTR_MAX <= UINT64_MAX
+# define MM_PTR_FMT_WIDTH 19
+#endif
+
+#ifndef ALIGN_UP
+#define ALIGN_UP(x, a) (((x) + ((a) - 1)) & (~((a) - 1)))
Review Comment:
add two space after #
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8139: [PATCH2]mm/backtrace: add backtrace for mempool and memdup for tlsf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8139:
URL: https://github.com/apache/nuttx/pull/8139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8139: [PATCH2]mm/backtrace: add backtrace for mempool and memdup for tlsf
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8139:
URL: https://github.com/apache/nuttx/pull/8139#issuecomment-1384911495
Let's ignore the ci broken which is fixed by https://github.com/apache/nuttx/pull/8158.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Donny9 commented on a diff in pull request #8139: [PATCH2]mm/backtrace: add backtrace for mempool and memdup for tlsf
Posted by GitBox <gi...@apache.org>.
Donny9 commented on code in PR #8139:
URL: https://github.com/apache/nuttx/pull/8139#discussion_r1071702907
##########
mm/mempool/mempool.c:
##########
@@ -22,13 +22,41 @@
* Included Files
****************************************************************************/
+#include <execinfo.h>
#include <stdbool.h>
+#include <stdio.h>
+#include <syslog.h>
#include <nuttx/kmalloc.h>
#include <nuttx/mm/mempool.h>
#include "kasan/kasan.h"
+#if UINTPTR_MAX <= UINT32_MAX
+# define MM_PTR_FMT_WIDTH 11
+#elif UINTPTR_MAX <= UINT64_MAX
+# define MM_PTR_FMT_WIDTH 19
+#endif
+
+#ifndef ALIGN_UP
+#define ALIGN_UP(x, a) (((x) + ((a) - 1)) & (~((a) - 1)))
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org