You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Honghai Chen <ho...@microsoft.com> on 2015/04/15 05:25:53 UTC
Review Request 33204: Patch for KAFKA-1646
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
Kafka 1646 fix against trunk
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 5563f2de8113a0ece8929bec9c75dbf892abbb66
core/src/main/scala/kafka/log/LogConfig.scala 558c703f26da22b1a938bbbf8a6c4409a8e107fb
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala 69b772c1941865fbe15b34bb2784c511f8ce519a
core/src/main/scala/kafka/server/KafkaServer.scala c63f4ba9d622817ea8636d4e6135fba917ce085a
core/src/main/scala/kafka/utils/CoreUtils.scala c473a034bc3a00ccddbbc0506388a5a7763df950
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Improve 1646 fix by add log.preallocate
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated June 19, 2015, 6:53 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix 2 test cases and log clean and merge to latest
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9
core/src/main/scala/kafka/log/LogConfig.scala e9af221299895d8b492438e8a0d0f2bbbd03fb3c
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala e0b248020c7f6b3f3e7305b688faea68e12bb31c
core/src/main/scala/kafka/server/KafkaServer.scala 9de2a6f49083ff34261c5a783aaddf56a7a04ce1
core/src/main/scala/kafka/utils/CoreUtils.scala f5d704c5a702d14c85fae31eaa34b450b60b4597
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogConfigTest.scala c31f8841bbbd3e70b77428d4a5784a02e56c651b
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala 826885298fbcfe6de1e3cae16fd85677991a540f
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Improve 1646 fix by add log.preallocate
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated June 19, 2015, 5:56 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Improve 1646 fix by add log.preallocate
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
-------
Kafka 1646 Fix2TestCasesAndLogClean
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9
core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88
core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4
core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/test/resources/log4j.properties 1b7d5d8f7d5fae7d272849715714781cad05d77b
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogConfigTest.scala f3546adee490891e0d8d0214bef00b1dd7f42227
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala ace6321b36d809946554d205bc926c9c76a43bd6
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Patch for KAFKA-1646
Fix2TestCasesAndLogClean
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated June 19, 2015, 5:55 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1646 Fix2TestCasesAndLogClean
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 Fix2TestCasesAndLogClean
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9
core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88
core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4
core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/test/resources/log4j.properties 1b7d5d8f7d5fae7d272849715714781cad05d77b
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogConfigTest.scala f3546adee490891e0d8d0214bef00b1dd7f42227
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala ace6321b36d809946554d205bc926c9c76a43bd6
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Patch for KAFKA-1646 fix format
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated June 16, 2015, 7:34 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1646 fix format
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix improvement
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88
core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4
core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/#review87450
-----------------------------------------------------------
Ship it!
Thanks for the patch. +1. Just some minor comments below.
core/src/main/scala/kafka/log/FileMessageSet.scala
<https://reviews.apache.org/r/33204/#comment139760>
Need space after if to be consistent with the rest of the code. There are a few other places like that.
core/src/main/scala/kafka/log/FileMessageSet.scala
<https://reviews.apache.org/r/33204/#comment139764>
It's probably clearer if we wrap this in {}.
core/src/main/scala/kafka/log/Log.scala
<https://reviews.apache.org/r/33204/#comment139767>
This check is not necessary since we already verify that the segment size is larger than 0 when parsing the configuration.
core/src/main/scala/kafka/server/KafkaConfig.scala
<https://reviews.apache.org/r/33204/#comment139765>
need set => need to set
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala
<https://reviews.apache.org/r/33204/#comment139768>
FileMessageSEt => FileMessageSet
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala
<https://reviews.apache.org/r/33204/#comment139769>
clear shutdown => cleanly shut down
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
<https://reviews.apache.org/r/33204/#comment139772>
clear shutdown => clean shutdown
- Jun Rao
On June 9, 2015, 3:02 a.m., Honghai Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33204/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 3:02 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Patch for KAFKA-1646 merge to latest trunk
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
> core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
> core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
> core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
> core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88
> core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4
> core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
> core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
> core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
>
> Diff: https://reviews.apache.org/r/33204/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Honghai Chen
>
>
Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated June 9, 2015, 3:02 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1646 merge to latest trunk
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Patch for KAFKA-1646 merge to latest trunk
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88
core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4
core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Patch for KAFKA-1646 add test cases
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/#review84554
-----------------------------------------------------------
Ship it!
This looks good to be, but it would be good to get a second reviewer since this is fairly critical code.
- Jay Kreps
On May 11, 2015, 10 a.m., Honghai Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33204/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Kafka 1646 fix add test cases
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
> core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
> core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
> core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
> core/src/main/scala/kafka/server/KafkaConfig.scala 9efa15ca5567b295ab412ee9eea7c03eb4cdc18b
> core/src/main/scala/kafka/server/KafkaServer.scala b7d2a2842e17411a823b93bdedc84657cbd62be1
> core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
> core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
> core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
>
> Diff: https://reviews.apache.org/r/33204/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Honghai Chen
>
>
Re: Review Request 33204: Patch for KAFKA-1646 add test cases
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated May 11, 2015, 10 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1646 add test cases
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix add test cases
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala 9efa15ca5567b295ab412ee9eea7c03eb4cdc18b
core/src/main/scala/kafka/server/KafkaServer.scala b7d2a2842e17411a823b93bdedc84657cbd62be1
core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen
Re: Review Request 33204: Patch for KAFKA-1646
Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------
(Updated April 22, 2015, 10:13 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix improve for set position correctly.
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala 5563f2de8113a0ece8929bec9c75dbf892abbb66
core/src/main/scala/kafka/log/LogConfig.scala da55a348f37a3d6d99032c39398f7ccb11068f42
core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala cfbbd2be550947dd2b3c8c2cab981fa08fb6d859
core/src/main/scala/kafka/server/KafkaServer.scala c63f4ba9d622817ea8636d4e6135fba917ce085a
core/src/main/scala/kafka/utils/CoreUtils.scala c473a034bc3a00ccddbbc0506388a5a7763df950
Diff: https://reviews.apache.org/r/33204/diff/
Testing
-------
Thanks,
Honghai Chen