You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wangsheng (Code Review)" <ge...@cloudera.org> on 2020/11/20 08:57:49 UTC

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific situations 

wangsheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16753


Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific situations
......................................................................

IMPALA-10346: Rename Iceberg test tables' name with specific situations

We used some unrecognized table names in Iceberg related test cases,
such as iceberg_tes1/iceberg_test2 and so on, which resulted in poor
readability. So we better rename these Iceberg test tables' name by
specific situations.

Testing:
  - Renamed tables' name in iceberg-create.test
  - Renamed tables' name in iceberg-alter.test

Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 62 insertions(+), 62 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/16753/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific situations

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific situations
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Thanks for making the tests more readable!

http://gerrit.cloudera.org:8080/#/c/16753/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16753/1//COMMIT_MSG@7
PS1, Line 7: situations
nit: probably the word 'cases' fits better here


http://gerrit.cloudera.org:8080/#/c/16753/1//COMMIT_MSG@10
PS1, Line 10: iceberg_tes1
nit: iceberg_test1



-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 10:25:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 16:21:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6684/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 10:56:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................

IMPALA-10346: Rename Iceberg test tables' name with specific cases

We used some unrecognized table names in Iceberg related test cases,
such as iceberg_test1/iceberg_test2 and so on, which resulted in poor
readability. So we better rename these Iceberg test tables' name by
specific cases.

Testing:
  - Renamed tables' name in iceberg-create.test
  - Renamed tables' name in iceberg-alter.test

Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 62 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/16753/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific situations

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific situations
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7693/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 09:19:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 11:47:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7696/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 11:17:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................

IMPALA-10346: Rename Iceberg test tables' name with specific cases

We used some unrecognized table names in Iceberg related test cases,
such as iceberg_test1/iceberg_test2 and so on, which resulted in poor
readability. So we better rename these Iceberg test tables' name by
specific cases.

Testing:
  - Renamed tables' name in iceberg-create.test
  - Renamed tables' name in iceberg-alter.test

Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Reviewed-on: http://gerrit.cloudera.org:8080/16753
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 62 insertions(+), 62 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10346: Rename Iceberg test tables' name with specific cases

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16753 )

Change subject: IMPALA-10346: Rename Iceberg test tables' name with specific cases
......................................................................


Patch Set 2:

(2 comments)

Thanks for review!

http://gerrit.cloudera.org:8080/#/c/16753/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16753/1//COMMIT_MSG@7
PS1, Line 7: cases
> nit: probably the word 'cases' fits better here
Done


http://gerrit.cloudera.org:8080/#/c/16753/1//COMMIT_MSG@10
PS1, Line 10: iceberg_test
> nit: iceberg_test1
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16753
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaeaaeed69753222668342dcac852677fdd9ae5
Gerrit-Change-Number: 16753
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 10:56:18 +0000
Gerrit-HasComments: Yes