You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Scott Banachowski (JIRA)" <ji...@apache.org> on 2010/01/19 00:56:54 UTC

[jira] Created: (AVRO-349) Make C++ builds work post AVRO-163

Make C++ builds work post AVRO-163
----------------------------------

                 Key: AVRO-349
                 URL: https://issues.apache.org/jira/browse/AVRO-349
             Project: Avro
          Issue Type: Improvement
            Reporter: Scott Banachowski


This makes the c++ builds work with the top-level build by doing the the following:

for build.sh test:
this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )

for build.sh dist:
this will build the html documentation, and copies the documentation to build/doc/cpp.
it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz

for build.sh clean:
this removes build/c++

Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-349:
------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0
         Assignee: Scott Banachowski
           Status: Resolved  (was: Patch Available)

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>            Assignee: Scott Banachowski
>             Fix For: 1.3.0
>
>         Attachments: apply349.sh, AVRO-349.patch, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Banachowski updated AVRO-349:
-----------------------------------

    Attachment: apply349.sh

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>         Attachments: apply349.sh, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802623#action_12802623 ] 

Matt Massie commented on AVRO-349:
----------------------------------

Scott-

bq. this will build the html documentation, and copies the documentation to build/doc/cpp.

I think the proper location for documentation would be {{build/avro-doc-$VERSION/api/c++/}}.  

If you look at the top-level build.sh, you see that it does...

{code}
(cd doc; ant)
(cd build; tar czf - avro-doc-$VERSION) > dist/avro-doc-$VERSION.tar.gz
{code}

...on "dist" to create the avro-doc tarball.

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>         Attachments: apply349.sh, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Banachowski updated AVRO-349:
-----------------------------------

    Attachment: AVRO-349.patch

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>         Attachments: apply349.sh, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802625#action_12802625 ] 

Matt Massie commented on AVRO-349:
----------------------------------

Scott-

bq. this will build the html documentation, and copies the documentation to build/doc/cpp.

I think the proper location for your docs would be {{build/avro-doc-$VERSION/api/c++}}.

If you look at the top-level {{build.sh}} script, you'll see that it does...

{code}
(cd doc; ant)
(cd build; tar czf - avro-doc-$VERSION) > dist/avro-doc-$VERSION.tar.gz
{code}

... when {{dist}} is run.

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>         Attachments: apply349.sh, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Banachowski updated AVRO-349:
-----------------------------------

    Status: Patch Available  (was: Open)

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>         Attachments: apply349.sh, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-349) Make C++ builds work post AVRO-163

Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Banachowski updated AVRO-349:
-----------------------------------

    Attachment: AVRO-349.patch

revised patch.

thanks for the comments Matt.  By the way, I'm going with cpp instead of c++ for documentation path names--I've seen the ++ get rendered as a single plus in some of the document pages before

> Make C++ builds work post AVRO-163
> ----------------------------------
>
>                 Key: AVRO-349
>                 URL: https://issues.apache.org/jira/browse/AVRO-349
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Scott Banachowski
>         Attachments: apply349.sh, AVRO-349.patch, AVRO-349.patch
>
>
> This makes the c++ builds work with the top-level build by doing the the following:
> for build.sh test:
> this will build the c++ code and run its unit tests (all build artifacts are written in to build/c++/ )
> for build.sh dist:
> this will build the html documentation, and copies the documentation to build/doc/cpp.
> it also builds a dist tarball that contains  the c++ code, and copies it to dist/avro-cpp-$version.tgz
> for build.sh clean:
> this removes build/c++
> Is this in-line with what is expected after AVRO-163?  Please let me know if there are some things I overlooked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.