You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/11/17 08:42:52 UTC
[GitHub] [cordova-android] raphinesse opened a new pull request #1123: refactor: unify installation on devices & emulators
raphinesse opened a new pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
`device.install` and `emulator.install` are virtually identical. The only real difference is that `emulator.install` has some retry logic that is supposed to mitigate emulator hangs. The same goes for the unit tests.
Furthermore, on the only calling site of these functions, it is easier to call a generic function.
Joining these methods reduces the code we have to maintain and makes upcoming refactors easier.
### Description
<!-- Describe your changes in detail -->
This change replaces `device.install` and `emulator.install` with the generic `target.install`.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Our unit tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse closed pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
raphinesse closed pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728779574
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=desc) (8d8afa9) into [master](https://codecov.io/gh/apache/cordova-android/commit/671e1fd1c60b58cd5061f5037cdfb2169ac21d60?el=desc) (671e1fd) will **decrease** coverage by `0.50%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 70.02% 69.52% -0.51%
==========================================
Files 20 21 +1
Lines 1775 1752 -23
==========================================
- Hits 1243 1218 -25
- Misses 532 534 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.83% <ø> (-0.19%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <96.77%> (ø)` | |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=footer). Last update [671e1fd...8d8afa9](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728779574
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=desc) (8d8afa9) into [master](https://codecov.io/gh/apache/cordova-android/commit/671e1fd1c60b58cd5061f5037cdfb2169ac21d60?el=desc) (671e1fd) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 70.02% 69.57% -0.46%
==========================================
Files 20 21 +1
Lines 1775 1752 -23
==========================================
- Hits 1243 1219 -24
- Misses 532 533 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.83% <ø> (-0.19%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <96.77%> (ø)` | |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=footer). Last update [671e1fd...8d8afa9](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728922219
OK, I fixed this PR up and it is now independent and ready to review. Sorry for the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728779574
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=desc) (8d8afa9) into [master](https://codecov.io/gh/apache/cordova-android/commit/671e1fd1c60b58cd5061f5037cdfb2169ac21d60?el=desc) (671e1fd) will **decrease** coverage by `0.45%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 70.02% 69.57% -0.46%
==========================================
Files 20 21 +1
Lines 1775 1752 -23
==========================================
- Hits 1243 1219 -24
- Misses 532 533 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.83% <ø> (-0.19%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <96.77%> (ø)` | |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=footer). Last update [671e1fd...8d8afa9](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728779574
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=desc) (6737629) into [master](https://codecov.io/gh/apache/cordova-android/commit/aa679ea1d6ddd63ce4a8d64925637e75482d5374?el=desc) (aa679ea) will **decrease** coverage by `0.43%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 71.41% 70.97% -0.44%
==========================================
Files 20 21 +1
Lines 1770 1747 -23
==========================================
- Hits 1264 1240 -24
- Misses 506 507 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <ø> (-0.19%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <96.77%> (ø)` | |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=footer). Last update [aa679ea...6737629](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728779574
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=desc) (8d8afa9) into [master](https://codecov.io/gh/apache/cordova-android/commit/671e1fd1c60b58cd5061f5037cdfb2169ac21d60?el=desc) (671e1fd) will **decrease** coverage by `0.50%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 70.02% 69.52% -0.51%
==========================================
Files 20 21 +1
Lines 1775 1752 -23
==========================================
- Hits 1243 1218 -25
- Misses 532 534 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.83% <ø> (-0.19%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <96.77%> (ø)` | |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=footer). Last update [671e1fd...8d8afa9](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728779574
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=desc) (6737629) into [master](https://codecov.io/gh/apache/cordova-android/commit/aa679ea1d6ddd63ce4a8d64925637e75482d5374?el=desc) (aa679ea) will **decrease** coverage by `0.54%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 71.41% 70.86% -0.55%
==========================================
Files 20 21 +1
Lines 1770 1747 -23
==========================================
- Hits 1264 1238 -26
- Misses 506 509 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <ø> (ø)` | |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <ø> (-0.19%)` | :arrow_down: |
| [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <96.77%> (ø)` | |
| [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <100.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1123/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.26% <0.00%> (-0.98%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=footer). Last update [aa679ea...6737629](https://codecov.io/gh/apache/cordova-android/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse commented on pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123#issuecomment-728786311
This change is actually not independent from #1101. Sorry for the bother. Closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] raphinesse merged pull request #1123: refactor: unify installation on devices & emulators
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #1123:
URL: https://github.com/apache/cordova-android/pull/1123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org