[GitHub] [hudi] nsivabalan commented on a change in pull request #3452: [HUDI-2151] Flipping defaults

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#discussion_r688481093



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -81,7 +81,7 @@
 
   public static final ConfigProperty<HoodieTableVersion> HOODIE_TABLE_VERSION_PROP = ConfigProperty
       .key("hoodie.table.version")
-      .defaultValue(HoodieTableVersion.ZERO)
+      .defaultValue(HoodieTableVersion.ONE)

Review comment:
       yes, HoodieTableMetaClient.PropertyBuilder set table version as below.
   ```
   tableConfig.setValue(HoodieTableConfig.HOODIE_TABLE_VERSION_PROP,
             String.valueOf(HoodieTableVersion.current().versionCode()));
   ```
   So, this default value is actually of no use. But will see how to test this out. 
   I guess, I might have to generate a table w/ 0.5.2. And then try to use this patch and see if upgrade happens. Upgrade here refers to tableversion 0 to 1 which happened w/ 0.6.0. 
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org