You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/30 12:01:27 UTC
[GitHub] [dubbo-samples] sourirer opened a new pull request #199: 对dubbo-sample-zookeeper部分的修改。
sourirer opened a new pull request #199:
URL: https://github.com/apache/dubbo-samples/pull/199
调整了pom依赖。
修改了引入zk。
增加了configuration文件。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] sourirer commented on a change in pull request #199: 对dubbo-sample-zookeeper部分的修改。
Posted by GitBox <gi...@apache.org>.
sourirer commented on a change in pull request #199:
URL: https://github.com/apache/dubbo-samples/pull/199#discussion_r550434751
##########
File path: dubbo-samples-zookeeper/case-configuration.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from: app-builtin-zookeeper.yml
Review comment:
并不是，之前使用的模板是自有zookeeper，pom.xml中的配置符合文档中的单服务配置样例，所以我才增加的这个。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #199: 对dubbo-sample-zookeeper部分的修改。
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #199:
URL: https://github.com/apache/dubbo-samples/pull/199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #199: 对dubbo-sample-zookeeper部分的修改。
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #199:
URL: https://github.com/apache/dubbo-samples/pull/199#discussion_r550171665
##########
File path: dubbo-samples-zookeeper/case-configuration.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from: app-builtin-zookeeper.yml
Review comment:
原来使用的是外部zookeeper，使用这个模板： `app-external-zookeeper.yml`
##########
File path: dubbo-samples-zookeeper/src/main/java/org/apache/dubbo/samples/EmbeddedZooKeeper.java
##########
@@ -0,0 +1,251 @@
+/*
Review comment:
原来使用的是外部zookeeper，不要加EmbeddedZooKeeper.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org